Re: [Qemu-devel] [RFC v3 01/27] char-io: fix possible race on IOWatchPoll

2017-11-15 Thread Peter Xu
On Wed, Nov 15, 2017 at 09:37:40AM +, Stefan Hajnoczi wrote: > On Tue, Nov 14, 2017 at 07:31:10PM +0800, Peter Xu wrote: > > On Tue, Nov 14, 2017 at 10:32:19AM +, Stefan Hajnoczi wrote: > > > On Tue, Nov 14, 2017 at 02:09:39PM +0800, Peter Xu wrote: > > > > On Mon, Nov 13, 2017 at

Re: [Qemu-devel] [RFC v3 01/27] char-io: fix possible race on IOWatchPoll

2017-11-15 Thread Stefan Hajnoczi
On Tue, Nov 14, 2017 at 07:31:10PM +0800, Peter Xu wrote: > On Tue, Nov 14, 2017 at 10:32:19AM +, Stefan Hajnoczi wrote: > > On Tue, Nov 14, 2017 at 02:09:39PM +0800, Peter Xu wrote: > > > On Mon, Nov 13, 2017 at 04:52:11PM +, Stefan Hajnoczi wrote: > > > > On Mon, Nov 06, 2017 at

Re: [Qemu-devel] [RFC v3 01/27] char-io: fix possible race on IOWatchPoll

2017-11-14 Thread Peter Xu
On Tue, Nov 14, 2017 at 10:32:19AM +, Stefan Hajnoczi wrote: > On Tue, Nov 14, 2017 at 02:09:39PM +0800, Peter Xu wrote: > > On Mon, Nov 13, 2017 at 04:52:11PM +, Stefan Hajnoczi wrote: > > > On Mon, Nov 06, 2017 at 05:46:17PM +0800, Peter Xu wrote: > > > > This is not a problem if we are

Re: [Qemu-devel] [RFC v3 01/27] char-io: fix possible race on IOWatchPoll

2017-11-14 Thread Stefan Hajnoczi
On Tue, Nov 14, 2017 at 02:09:39PM +0800, Peter Xu wrote: > On Mon, Nov 13, 2017 at 04:52:11PM +, Stefan Hajnoczi wrote: > > On Mon, Nov 06, 2017 at 05:46:17PM +0800, Peter Xu wrote: > > > This is not a problem if we are only having one single loop thread like > > > before. However, after

Re: [Qemu-devel] [RFC v3 01/27] char-io: fix possible race on IOWatchPoll

2017-11-13 Thread Peter Xu
On Mon, Nov 13, 2017 at 04:52:11PM +, Stefan Hajnoczi wrote: > On Mon, Nov 06, 2017 at 05:46:17PM +0800, Peter Xu wrote: > > This is not a problem if we are only having one single loop thread like > > before. However, after per-monitor thread is introduced, this is not > > true any more, and

Re: [Qemu-devel] [RFC v3 01/27] char-io: fix possible race on IOWatchPoll

2017-11-13 Thread Stefan Hajnoczi
On Mon, Nov 06, 2017 at 05:46:17PM +0800, Peter Xu wrote: > This is not a problem if we are only having one single loop thread like > before. However, after per-monitor thread is introduced, this is not > true any more, and the race can happen. > > The race can be triggered with "make check -j8"

Re: [Qemu-devel] [RFC v3 01/27] char-io: fix possible race on IOWatchPoll

2017-11-06 Thread Fam Zheng
On Mon, 11/06 17:46, Peter Xu wrote: > This is not a problem if we are only having one single loop thread like > before. However, after per-monitor thread is introduced, this is not > true any more, and the race can happen. > > The race can be triggered with "make check -j8" sometimes: > >

[Qemu-devel] [RFC v3 01/27] char-io: fix possible race on IOWatchPoll

2017-11-06 Thread Peter Xu
This is not a problem if we are only having one single loop thread like before. However, after per-monitor thread is introduced, this is not true any more, and the race can happen. The race can be triggered with "make check -j8" sometimes: qemu-system-x86_64: