Re: [Qemu-devel] [RFC v3 18/27] qmp: add new event "request-dropped"

2017-11-15 Thread Peter Xu
On Thu, Nov 16, 2017 at 02:29:05PM +0800, Peter Xu wrote: [...] > > > > +# > > > > +# @id:If the original request contains an string-typed "id" field, > > > > +# it'll be put into this field. Otherwise it'll be an empty > > > > +# string. > > > > > > Please change: > > > >

Re: [Qemu-devel] [RFC v3 18/27] qmp: add new event "request-dropped"

2017-11-15 Thread Peter Xu
On Thu, Nov 16, 2017 at 01:56:54PM +0800, Peter Xu wrote: > On Wed, Nov 15, 2017 at 10:50:15AM +, Stefan Hajnoczi wrote: > > On Mon, Nov 06, 2017 at 05:46:34PM +0800, Peter Xu wrote: > > > diff --git a/qapi-schema.json b/qapi-schema.json > > > index 531fd4c0db..650714da06 100644 > > > --- a/qap

Re: [Qemu-devel] [RFC v3 18/27] qmp: add new event "request-dropped"

2017-11-15 Thread Peter Xu
On Wed, Nov 15, 2017 at 10:50:15AM +, Stefan Hajnoczi wrote: > On Mon, Nov 06, 2017 at 05:46:34PM +0800, Peter Xu wrote: > > diff --git a/qapi-schema.json b/qapi-schema.json > > index 531fd4c0db..650714da06 100644 > > --- a/qapi-schema.json > > +++ b/qapi-schema.json > > @@ -3222,3 +3222,38 @@

Re: [Qemu-devel] [RFC v3 18/27] qmp: add new event "request-dropped"

2017-11-15 Thread Stefan Hajnoczi
On Mon, Nov 06, 2017 at 05:46:34PM +0800, Peter Xu wrote: > diff --git a/qapi-schema.json b/qapi-schema.json > index 531fd4c0db..650714da06 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3222,3 +3222,38 @@ > # Since: 2.11 > ## > { 'command': 'watchdog-set-action', 'data' : {'acti

[Qemu-devel] [RFC v3 18/27] qmp: add new event "request-dropped"

2017-11-06 Thread Peter Xu
This event will be emitted if one QMP request is dropped. Along, declare an enum for the reasons. Signed-off-by: Peter Xu --- qapi-schema.json | 35 +++ 1 file changed, 35 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 531fd4c0db..650714da0