Re: [Qemu-devel] [RFC v4 18/21] blockjobs: add block-job-finalize

2018-03-01 Thread John Snow
On 03/01/2018 05:01 AM, Kevin Wolf wrote: > Am 28.02.2018 um 20:14 hat John Snow geschrieben: >> >> >> On 02/28/2018 01:15 PM, Kevin Wolf wrote: >>> Is it because you want to avoid that the user picks an automatic job for >>> completing the mixed transaction? >> >> I wanted to avoid the case

Re: [Qemu-devel] [RFC v4 18/21] blockjobs: add block-job-finalize

2018-03-01 Thread Kevin Wolf
Am 28.02.2018 um 20:14 hat John Snow geschrieben: > > > On 02/28/2018 01:15 PM, Kevin Wolf wrote: > > Is it because you want to avoid that the user picks an automatic job for > > completing the mixed transaction? > > I wanted to avoid the case that a job without the manual property would > be

Re: [Qemu-devel] [RFC v4 18/21] blockjobs: add block-job-finalize

2018-02-28 Thread John Snow
On 02/28/2018 01:15 PM, Kevin Wolf wrote: > Is it because you want to avoid that the user picks an automatic job for > completing the mixed transaction? I wanted to avoid the case that a job without the manual property would be stuck "pending" -- which I have defined to mean that it is waiting

Re: [Qemu-devel] [RFC v4 18/21] blockjobs: add block-job-finalize

2018-02-28 Thread Kevin Wolf
Am 24.02.2018 um 00:51 hat John Snow geschrieben: > Instead of automatically transitioning from PENDING to CONCLUDED, gate > the .prepare() and .commit() phases behind an explicit acknowledgement > provided by the QMP monitor if manual completion mode has been requested. > > This allows us to

Re: [Qemu-devel] [RFC v4 18/21] blockjobs: add block-job-finalize

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: Instead of automatically transitioning from PENDING to CONCLUDED, gate the .prepare() and .commit() phases behind an explicit acknowledgement provided by the QMP monitor if manual completion mode has been requested. This allows us to perform graph

[Qemu-devel] [RFC v4 18/21] blockjobs: add block-job-finalize

2018-02-23 Thread John Snow
Instead of automatically transitioning from PENDING to CONCLUDED, gate the .prepare() and .commit() phases behind an explicit acknowledgement provided by the QMP monitor if manual completion mode has been requested. This allows us to perform graph changes in prepare and/or commit so that graph