Re: [Qemu-devel] [RFT][PATCH 05/15] hpet: Convert to qdev

2010-05-25 Thread Paul Brook
+static SysBusDeviceInfo hpet_device_info = { +.qdev.name= hpet, +.qdev.size= sizeof(HPETState), +.qdev.no_user = 1, Why shouldn't the user create HPET devices? I thought you'd removed all the global state. Paul

Re: [Qemu-devel] [RFT][PATCH 05/15] hpet: Convert to qdev

2010-05-25 Thread Jan Kiszka
Paul Brook wrote: +static SysBusDeviceInfo hpet_device_info = { +.qdev.name= hpet, +.qdev.size= sizeof(HPETState), +.qdev.no_user = 1, Why shouldn't the user create HPET devices? I thought you'd removed all the global state. Long-term, there is no reason to deny this.

[Qemu-devel] [RFT][PATCH 05/15] hpet: Convert to qdev

2010-05-24 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Register the HPET as a sysbus device and create it that way. As it can route its IRQs to any ISA IRQ, we need to connect it to all 24 of them. Once converted to qdev, we can move reset handler and vmstate registration into its hands as well. Signed-off-by: