Re: [Qemu-devel] [RfC PATCH] Fix vnc memory corruption with width = 1400

2010-06-15 Thread Markus Armbruster
Gerd Hoffmann writes: > vnc assumes that the screen width is a multiple of 16 in several places. > If this is not the case vnc will overrun buffers, corrupt memory, make > qemu crash. > > This is the minimum fix for this bug. It makes sure we don't overrun the > scanline, thereby fixing the segfa

[Qemu-devel] [RfC PATCH] Fix vnc memory corruption with width = 1400

2010-06-14 Thread Gerd Hoffmann
vnc assumes that the screen width is a multiple of 16 in several places. If this is not the case vnc will overrun buffers, corrupt memory, make qemu crash. This is the minimum fix for this bug. It makes sure we don't overrun the scanline, thereby fixing the segfault. The rendering is *not* correc