Re: [Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for q35-pcihost

2013-05-29 Thread Kevin O'Connor
On Wed, May 29, 2013 at 10:33:54AM +0800, Amos Kong wrote: > On Tue, May 28, 2013 at 06:59:02PM -0400, Kevin O'Connor wrote: > > On Tue, May 28, 2013 at 08:28:14PM +0800, Amos Kong wrote: > > > -#define FW_PCI_DOMAIN "/pci@i0cf8" > > > +#define FW_PCI_DOMAIN "/*pci*@i0cf8" > > > > The seabios patt

Re: [Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for q35-pcihost

2013-05-28 Thread Amos Kong
On Tue, May 28, 2013 at 06:59:02PM -0400, Kevin O'Connor wrote: > On Tue, May 28, 2013 at 08:28:14PM +0800, Amos Kong wrote: > > Bootindex string passed from qemu: > > /q35-pcihost@i0cf8/ethernet@2/ethernet-phy@0 > > > > We match pci domain by "/pci@i0cf8" in SeaBIOS, but fw_dev_path prefix > > o

Re: [Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for q35-pcihost

2013-05-28 Thread Kevin O'Connor
On Tue, May 28, 2013 at 08:28:14PM +0800, Amos Kong wrote: > Bootindex string passed from qemu: > /q35-pcihost@i0cf8/ethernet@2/ethernet-phy@0 > > We match pci domain by "/pci@i0cf8" in SeaBIOS, but fw_dev_path prefix > of q35 is "/q35-pcihost@i0cf8". So bootindex in qemu commandline > doesn't wo

Re: [Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for q35-pcihost

2013-05-28 Thread Paolo Bonzini
Il 28/05/2013 14:28, Amos Kong ha scritto: > Bootindex string passed from qemu: > /q35-pcihost@i0cf8/ethernet@2/ethernet-phy@0 > > We match pci domain by "/pci@i0cf8" in SeaBIOS, but fw_dev_path prefix > of q35 is "/q35-pcihost@i0cf8". So bootindex in qemu commandline > doesn't work if it uses q3

[Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for q35-pcihost

2013-05-28 Thread Amos Kong
Bootindex string passed from qemu: /q35-pcihost@i0cf8/ethernet@2/ethernet-phy@0 We match pci domain by "/pci@i0cf8" in SeaBIOS, but fw_dev_path prefix of q35 is "/q35-pcihost@i0cf8". So bootindex in qemu commandline doesn't work if it uses q35 machine type. This patch fixes the pattern to match