Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/29/19 5:53 PM, Philippe Mathieu-Daudé wrote: > On 8/29/19 5:43 PM, Philippe Mathieu-Daudé wrote: >> On 8/26/19 12:54 AM, Samuel Thibault wrote: >>> Philippe Mathieu-Daudé, le ven. 23 août 2019 17:15:32 +0200, a ecrit: > Did you make your test with commit 126c04acbabd ("Fix heap overflow

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/29/19 5:43 PM, Philippe Mathieu-Daudé wrote: > On 8/26/19 12:54 AM, Samuel Thibault wrote: >> Philippe Mathieu-Daudé, le ven. 23 août 2019 17:15:32 +0200, a ecrit: Did you make your test with commit 126c04acbabd ("Fix heap overflow in ip_reass on big packet input") applied? >>> >>>

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-29 Thread Philippe Mathieu-Daudé
Hi Samuel, On 8/26/19 12:54 AM, Samuel Thibault wrote: > Hello, > > Philippe Mathieu-Daudé, le ven. 23 août 2019 17:15:32 +0200, a ecrit: >>> Did you make your test with commit 126c04acbabd ("Fix heap overflow in >>> ip_reass on big packet input") applied? >> >> Yes, unfortunately it doesn't fix

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-29 Thread P J P
+-- On Mon, 26 Aug 2019, Samuel Thibault wrote --+ | Philippe Mathieu-Daudé, le ven. 23 août 2019 17:15:32 +0200, a ecrit: | > > Did you make your test with commit 126c04acbabd ("Fix heap overflow in | > > ip_reass on big packet input") applied? | > | > Yes, unfortunately it doesn't fix the

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-25 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le ven. 23 août 2019 17:15:32 +0200, a ecrit: > > Did you make your test with commit 126c04acbabd ("Fix heap overflow in > > ip_reass on big packet input") applied? > > Yes, unfortunately it doesn't fix the issue. Ok. Could you try the attached patch? There was

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-23 Thread Philippe Mathieu-Daudé
On 8/22/19 8:33 PM, Samuel Thibault wrote: > Philippe Mathieu-Daudé, le jeu. 22 août 2019 16:41:33 +0200, a ecrit: >> Later the newly calculated pointer q is converted into ip structure >> and values are modified, Due to the wrong calculation of the delta, >> ip will be pointing to incorrect

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-22 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le jeu. 22 août 2019 16:41:33 +0200, a ecrit: > Later the newly calculated pointer q is converted into ip structure > and values are modified, Due to the wrong calculation of the delta, > ip will be pointing to incorrect location and ip_src and ip_dst can >