Re: [Qemu-devel] [V2 PATCH] rtl8139: check the buffer availiability

2011-10-21 Thread Jason Wang
On 10/18/2011 06:09 PM, Mark Wu wrote: Hi Jason, Could you please elaborate what problem you try to resolve by this patch? And do you think we need notify I/O thread re-polling tap fd when receive descriptor becomes available? Otherwise, tap read polling will be disabled until the I/O

Re: [Qemu-devel] [V2 PATCH] rtl8139: check the buffer availiability

2011-10-21 Thread Jason Wang
On 10/19/2011 09:28 AM, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 10:55:57AM +0800, Jason Wang wrote: Reduce spurious packet drops on RX ring empty when in c+ mode by verifying that we have at least 1 buffer ahead of the time. Change from v1: Fix style comments from Stefan.

Re: [Qemu-devel] [V2 PATCH] rtl8139: check the buffer availiability

2011-10-18 Thread Mark Wu
Hi Jason, Could you please elaborate what problem you try to resolve by this patch? And do you think we need notify I/O thread re-polling tap fd when receive descriptor becomes available? Otherwise, tap read polling will be disabled until the I/O handlers are updated by other reasons. Am I

Re: [Qemu-devel] [V2 PATCH] rtl8139: check the buffer availiability

2011-10-18 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 10:55:57AM +0800, Jason Wang wrote: Reduce spurious packet drops on RX ring empty when in c+ mode by verifying that we have at least 1 buffer ahead of the time. Change from v1: Fix style comments from Stefan. Signed-off-by: Jason Wang jasow...@redhat.com ---

[Qemu-devel] [V2 PATCH] rtl8139: check the buffer availiability

2011-10-16 Thread Jason Wang
Reduce spurious packet drops on RX ring empty when in c+ mode by verifying that we have at least 1 buffer ahead of the time. Change from v1: Fix style comments from Stefan. Signed-off-by: Jason Wang jasow...@redhat.com --- hw/rtl8139.c | 44 ++-- 1