Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-12 Thread Dr. David Alan Gilbert
* piaojun (piao...@huawei.com) wrote: > > > On 2019/8/12 18:05, Stefan Hajnoczi wrote: > > On Sun, Aug 11, 2019 at 10:26:18AM +0800, piaojun wrote: > >> On 2019/8/9 16:21, Stefan Hajnoczi wrote: > >>> On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: > * Stefan

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-12 Thread piaojun
On 2019/8/12 18:05, Stefan Hajnoczi wrote: > On Sun, Aug 11, 2019 at 10:26:18AM +0800, piaojun wrote: >> On 2019/8/9 16:21, Stefan Hajnoczi wrote: >>> On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: * Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Wed, Aug

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-12 Thread Stefan Hajnoczi
On Sun, Aug 11, 2019 at 10:26:18AM +0800, piaojun wrote: > On 2019/8/9 16:21, Stefan Hajnoczi wrote: > > On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: > >> * Stefan Hajnoczi (stefa...@redhat.com) wrote: > >>> On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: >

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-10 Thread piaojun
On 2019/8/9 16:21, Stefan Hajnoczi wrote: > On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: >> * Stefan Hajnoczi (stefa...@redhat.com) wrote: >>> On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: >>> 2. Can MAP/UNMAP be performed directly in QEMU via a

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-10 Thread Liu Bo
On Thu, Aug 08, 2019 at 08:53:20AM -0400, Vivek Goyal wrote: > On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: > > > > Kernel also serializes MAP/UNMAP on

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-10 Thread Liu Bo
On Fri, Aug 09, 2019 at 09:21:02AM +0100, Stefan Hajnoczi wrote: > On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: > > > 2. Can MAP/UNMAP be performed

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-09 Thread Stefan Hajnoczi
On Thu, Aug 08, 2019 at 08:53:20AM -0400, Vivek Goyal wrote: > On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: > > > > Kernel also serializes MAP/UNMAP on

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-09 Thread Stefan Hajnoczi
On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: > > 2. Can MAP/UNMAP be performed directly in QEMU via a separate virtqueue? > > I think there's two things to

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-08 Thread Vivek Goyal
On Thu, Aug 08, 2019 at 10:53:16AM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: > > > Kernel also serializes MAP/UNMAP on one inode. So you will need to run > > > multiple jobs operating on

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-08 Thread Stefan Hajnoczi
On Thu, Aug 08, 2019 at 04:10:00PM +0800, piaojun wrote: > From my test, your patch set of multithreading improves iops greatly as > below: Thank you for sharing your results! Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-08 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: > > Kernel also serializes MAP/UNMAP on one inode. So you will need to run > > multiple jobs operating on different inodes to see parallel MAP/UNMAP > > (atleast from kernel's point of

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-08 Thread Stefan Hajnoczi
On Wed, Aug 07, 2019 at 04:57:15PM -0400, Vivek Goyal wrote: > Kernel also serializes MAP/UNMAP on one inode. So you will need to run > multiple jobs operating on different inodes to see parallel MAP/UNMAP > (atleast from kernel's point of view). Okay, there is still room to experiment with how

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-08 Thread piaojun
Hi Stefan, >From my test, your patch set of multithreading improves iops greatly as below: Guest configuration: 8 vCPU 8GB RAM Linux 5.1 (vivek-aug-06-2019) Host configuration: Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz (8 cores x 4 threads) 32GB RAM Linux 3.10.0 EXT4 + LVM + local HDD ---

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-07 Thread Vivek Goyal
On Wed, Aug 07, 2019 at 07:03:55PM +0100, Stefan Hajnoczi wrote: > On Thu, Aug 01, 2019 at 05:54:05PM +0100, Stefan Hajnoczi wrote: > > Performance > > --- > > Please try these patches out and share your results. > > Here are the performance numbers: > > Threadpool | iodepth | iodepth

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-05 Thread piaojun
Hi Stefan, On 2019/8/5 16:01, Stefan Hajnoczi wrote: > On Mon, Aug 05, 2019 at 10:52:21AM +0800, piaojun wrote: >> # fio -direct=1 -time_based -iodepth=1 -rw=randwrite -ioengine=libaio -bs=1M >> -size=1G -numjob=1 -runtime=30 -group_reporting -name=file >> -filename=/mnt/9pshare/file > > This

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-05 Thread Stefan Hajnoczi
On Mon, Aug 05, 2019 at 10:52:21AM +0800, piaojun wrote: > # fio -direct=1 -time_based -iodepth=1 -rw=randwrite -ioengine=libaio -bs=1M > -size=1G -numjob=1 -runtime=30 -group_reporting -name=file > -filename=/mnt/9pshare/file This benchmark configuration (--iodepth=1 --numjobs=1) cannot

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-04 Thread piaojun
Hi Stefan, >From my test, 9p has better bandwidth than virtio as below: --- 9p Test: # mount -t 9p -o trans=virtio,version=9p2000.L,rw,nodev,msize=10,access=client 9pshare /mnt/9pshare # fio -direct=1 -time_based -iodepth=1 -rw=randwrite -ioengine=libaio -bs=1M -size=1G -numjob=1