Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 02:10, Laszlo Ersek ha scritto: OTOH if the keyboard reset gets soft in qemu, then OVMF's hard reset (the above code) will break. Maybe I could cycle between 0xCF9 and 0x64 in ResetCold(), starting with 0xCF9. Yes, that's the right thing to do. Also, in QEMU you're doing:

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread David Woodhouse
On Thu, 2013-02-21 at 09:36 +0100, Paolo Bonzini wrote: Il 21/02/2013 02:10, Laszlo Ersek ha scritto: OTOH if the keyboard reset gets soft in qemu, then OVMF's hard reset (the above code) will break. Maybe I could cycle between 0xCF9 and 0x64 in ResetCold(), starting with 0xCF9. Yes,

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread David Woodhouse
On Thu, 2013-02-21 at 02:10 +0100, Laszlo Ersek wrote: On 02/21/13 00:55, David Woodhouse wrote: Well... your test now works because of the bug that Anthony is trying to fix :) I don't believe so, Ok, for the *specific* variant of the test that you did. But there are many tests you could

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Anthony Liguori
David Woodhouse dw...@infradead.org writes: On Thu, 2013-02-21 at 02:10 +0100, Laszlo Ersek wrote: On 02/21/13 00:55, David Woodhouse wrote: Well... your test now works because of the bug that Anthony is trying to fix :) I don't believe so, Ok, for the *specific* variant of the test

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread David Woodhouse
On Thu, 2013-02-21 at 08:37 -0600, Anthony Liguori wrote: Help me understand where we're at. If you fix the bugs in UEFI and SeaBIOS, and I correct the reset patches I pointed you at earlier, we're good? Yes. And merge the bit which resets the PAM configuration in the i440FX on a hard

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Laszlo Ersek
On 02/21/13 09:36, Paolo Bonzini wrote: Il 21/02/2013 02:10, Laszlo Ersek ha scritto: OTOH if the keyboard reset gets soft in qemu, then OVMF's hard reset (the above code) will break. Maybe I could cycle between 0xCF9 and 0x64 in ResetCold(), starting with 0xCF9. Yes, that's the right thing

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Laszlo Ersek
On 02/21/13 15:37, Anthony Liguori wrote: David Woodhouse dw...@infradead.org writes: On Thu, 2013-02-21 at 02:10 +0100, Laszlo Ersek wrote: On 02/21/13 00:55, David Woodhouse wrote: Well... your test now works because of the bug that Anthony is trying to fix :) I don't believe so, Ok,

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread David Woodhouse
On Thu, 2013-02-21 at 18:10 +0100, Laszlo Ersek wrote: Since - I like kvm, and - I cannot easily change my hardware (which doesn't support UG), and - I prefer to run the RHEL-6 kernel which has old KVM, I depend on David's fix for the PAM registers. Which means your suspend/resume is broken.

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 18:12, David Woodhouse ha scritto: Since - I like kvm, and - I cannot easily change my hardware (which doesn't support UG), and - I prefer to run the RHEL-6 kernel which has old KVM, I depend on David's fix for the PAM registers. Which means your suspend/resume is broken.

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Laszlo Ersek
On 02/21/13 18:12, David Woodhouse wrote: On Thu, 2013-02-21 at 18:10 +0100, Laszlo Ersek wrote: Since - I like kvm, and - I cannot easily change my hardware (which doesn't support UG), and - I prefer to run the RHEL-6 kernel which has old KVM, I depend on David's fix for the PAM registers.

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Anthony Liguori
David Woodhouse dw...@infradead.org writes: On Thu, 2013-02-21 at 18:10 +0100, Laszlo Ersek wrote: Since - I like kvm, and - I cannot easily change my hardware (which doesn't support UG), and - I prefer to run the RHEL-6 kernel which has old KVM, I depend on David's fix for the PAM

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 21/02/2013 18:12, David Woodhouse ha scritto: Since - I like kvm, and - I cannot easily change my hardware (which doesn't support UG), and - I prefer to run the RHEL-6 kernel which has old KVM, I depend on David's fix for the PAM registers.