Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-29 Thread Markus Armbruster
Pavel Hrdina writes: > On Fri, Mar 29, 2019 at 11:12:55AM +0100, Markus Armbruster wrote: >> Pavel Hrdina writes: >> >> > On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote: >> >> Eric Blake writes: >> >> >> >> > On 3/28/19 3:06 PM, Eric Blake wrote: >> >> >> On 3/28/19 2:32 PM

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-29 Thread Pavel Hrdina
On Fri, Mar 29, 2019 at 11:12:55AM +0100, Markus Armbruster wrote: > Pavel Hrdina writes: > > > On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote: > >> Eric Blake writes: > >> > >> > On 3/28/19 3:06 PM, Eric Blake wrote: > >> >> On 3/28/19 2:32 PM, Markus Armbruster wrote: > >>

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-29 Thread Markus Armbruster
Pavel Hrdina writes: > On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote: >> Eric Blake writes: >> >> > On 3/28/19 3:06 PM, Eric Blake wrote: >> >> On 3/28/19 2:32 PM, Markus Armbruster wrote: >> >>> Markus Armbruster writes: >> Pavel Hrdina writes: >> >> >> > I'm gl

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-29 Thread Pavel Hrdina
On Fri, Mar 29, 2019 at 08:19:55AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > On 3/28/19 3:06 PM, Eric Blake wrote: > >> On 3/28/19 2:32 PM, Markus Armbruster wrote: > >>> Markus Armbruster writes: > Pavel Hrdina writes: > >> > > I'm glad that this is merged now and I

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-29 Thread Markus Armbruster
Eric Blake writes: > On 3/28/19 3:06 PM, Eric Blake wrote: >> On 3/28/19 2:32 PM, Markus Armbruster wrote: >>> Markus Armbruster writes: Pavel Hrdina writes: >> > I'm glad that this is merged now and I wanted to start working on > libvirt patches, but there is one big issue with t

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-28 Thread Eric Blake
On 3/28/19 3:06 PM, Eric Blake wrote: > On 3/28/19 2:32 PM, Markus Armbruster wrote: > Adding Markus to CC so we can figure out how to wire up the introspection for such command line options. >>> > > Alternative 6: > > Don't worry about patching q-c-l-o, but instead patch query-qemu-f

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-28 Thread Eric Blake
On 3/28/19 2:32 PM, Markus Armbruster wrote: >>> Adding Markus to CC so we can figure out how to wire up the >>> introspection for such command line options. >> >> query-command-line-options has always been woefully incomplete. Sadly, >> my replacement is still not ready. >> >> A reliable "witnes

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-28 Thread Markus Armbruster
Markus Armbruster writes: > Pavel Hrdina writes: > >> On Tue, Mar 12, 2019 at 08:12:40AM +0100, Gerd Hoffmann wrote: >>> From: Kővágó, Zoltán >>> >>> Audio drivers now get an Audiodev * as config paramters, instead of the >>> global audio_option structs. There is some code in audio/audio_lega

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-15 Thread Markus Armbruster
Pavel Hrdina writes: > On Tue, Mar 12, 2019 at 08:12:40AM +0100, Gerd Hoffmann wrote: >> From: Kővágó, Zoltán >> >> Audio drivers now get an Audiodev * as config paramters, instead of the >> global audio_option structs. There is some code in audio/audio_legacy.c >> that converts the old enviro

Re: [Qemu-devel] [libvirt] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-15 Thread Pavel Hrdina
On Tue, Mar 12, 2019 at 08:12:40AM +0100, Gerd Hoffmann wrote: > From: Kővágó, Zoltán > > Audio drivers now get an Audiodev * as config paramters, instead of the > global audio_option structs. There is some code in audio/audio_legacy.c > that converts the old environment variables to audiodev op