[Qemu-devel] [patch] use socklen_t with getsockopt()

2007-06-23 Thread Mike Frysinger
obvious fixup ... getsockopt() takes a socklen_t, not an int -mike signature.asc Description: This is a digitally signed message part. --- linux-user/syscall.c +++ linux-user/syscall.c @@ -642,7 +642,8 @@ static long do_setsockopt(int sockfd, in static long do_getsockopt(int sockfd, int level,

Re: [Qemu-devel] [patch] use socklen_t with getsockopt()

2007-04-10 Thread Jamie Lokier
Mike Frysinger wrote: On Thursday 05 April 2007, Jamie Lokier wrote: Sylvain Petreolle wrote: Was incorrect before too, since it was sizeof(int) in the first place ? The old type of val was int, so it made no different to the size. When val is of type socklen_t, it matters. val is

Re: [Qemu-devel] [patch] use socklen_t with getsockopt()

2007-04-06 Thread Mike Frysinger
On Thursday 05 April 2007, Jamie Lokier wrote: Sylvain Petreolle wrote: Was incorrect before too, since it was sizeof(int) in the first place ? The old type of val was int, so it made no different to the size. When val is of type socklen_t, it matters. val is still of type int which is fine

Re: [Qemu-devel] [patch] use socklen_t with getsockopt()

2007-04-06 Thread Paul Brook
On Friday 06 April 2007 22:51, Mike Frysinger wrote: On Thursday 05 April 2007, Jamie Lokier wrote: Sylvain Petreolle wrote: Was incorrect before too, since it was sizeof(int) in the first place ? The old type of val was int, so it made no different to the size. When val is of type

Re : [Qemu-devel] [patch] use socklen_t with getsockopt()

2007-04-05 Thread Sylvain Petreolle
Was incorrect before too, since it was sizeof(int) in the first place ? Sylvain - Message d'origine De : Thiemo Seufer [EMAIL PROTECTED] À : Mike Frysinger [EMAIL PROTECTED] Cc : Qemu-devel@nongnu.org Envoyé le : Dimanche, 1 Avril 2007, 20h43mn 02s Objet : Re: [Qemu-devel] [patch] use

Re: Re : [Qemu-devel] [patch] use socklen_t with getsockopt()

2007-04-05 Thread Jamie Lokier
Sylvain Petreolle wrote: Was incorrect before too, since it was sizeof(int) in the first place ? The old type of val was int, so it made no different to the size. When val is of type socklen_t, it matters. -- Jamie

Re: [Qemu-devel] [patch] use socklen_t with getsockopt()

2007-04-01 Thread Thiemo Seufer
Mike Frysinger wrote: obvious fixup ... getsockopt() takes a socklen_t, not an int -mike This is incorrect. Its initial value is sizeof(val). Thiemo

Re: [Qemu-devel] [patch] use socklen_t with getsockopt()

2007-04-01 Thread Mike Frysinger
On Sunday 01 April 2007, Thiemo Seufer wrote: Mike Frysinger wrote: obvious fixup ... getsockopt() takes a socklen_t, not an int This is incorrect. Its initial value is sizeof(val). attached -mike pgpxUDF1iyg7E.pgp Description: PGP signature --- linux-user/syscall.c +++

[Qemu-devel] [patch] use socklen_t with getsockopt()

2007-03-31 Thread Mike Frysinger
obvious fixup ... getsockopt() takes a socklen_t, not an int -mike pgpmFlADRziAp.pgp Description: PGP signature --- linux-user/syscall.c +++ linux-user/syscall.c @@ -642,7 +642,8 @@ static long do_setsockopt(int sockfd, in static long do_getsockopt(int sockfd, int level, int optname,