Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread Cornelia Huck
On Wed, 18 Jul 2018 10:50:01 +0200 David Hildenbrand wrote: > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > index cfdbccf46d..604898a882 100644 > --- a/target/s390x/cpu_models.c > +++ b/target/s390x/cpu_models.c > @@ -716,6 +716,14 @@ CpuModelBaselineInfo >

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread David Hildenbrand
On 18.07.2018 10:44, Christian Borntraeger wrote: > > > On 07/18/2018 10:40 AM, David Hildenbrand wrote: >> On 18.07.2018 10:39, Christian Borntraeger wrote: >>> >>> >>> On 07/18/2018 10:24 AM, David Hildenbrand wrote: Usually, when baselining two CPU models, whereby one of them has base

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread Cornelia Huck
On Wed, 18 Jul 2018 10:40:18 +0200 David Hildenbrand wrote: > On 18.07.2018 10:39, Christian Borntraeger wrote: > > > > > > On 07/18/2018 10:24 AM, David Hildenbrand wrote: > >> Usually, when baselining two CPU models, whereby one of them has base > >> CPU features disabled (e.g.

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread Christian Borntraeger
On 07/18/2018 10:40 AM, David Hildenbrand wrote: > On 18.07.2018 10:39, Christian Borntraeger wrote: >> >> >> On 07/18/2018 10:24 AM, David Hildenbrand wrote: >>> Usually, when baselining two CPU models, whereby one of them has base >>> CPU features disabled (e.g. z14-base,msa=off), we fallback

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread David Hildenbrand
On 18.07.2018 10:39, Christian Borntraeger wrote: > > > On 07/18/2018 10:24 AM, David Hildenbrand wrote: >> Usually, when baselining two CPU models, whereby one of them has base >> CPU features disabled (e.g. z14-base,msa=off), we fallback to an older >> model that did not have these features in

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/cpumodel: fix segmentation fault when baselining models

2018-07-18 Thread Christian Borntraeger
On 07/18/2018 10:24 AM, David Hildenbrand wrote: > Usually, when baselining two CPU models, whereby one of them has base > CPU features disabled (e.g. z14-base,msa=off), we fallback to an older > model that did not have these features in the base model. We always try to > create a "sane" CPU