Re: [Qemu-devel] [qemu-s390x] [PATCH v8 3/6] s390x/kvm: enable/disable AP instruction interpretation for guest

2018-09-20 Thread Cornelia Huck
On Wed, 19 Sep 2018 10:18:39 +0200 David Hildenbrand wrote: > My suggestion, either > a) Only use KVM_S390_VM_CPU_FEAT_AP to indicate/enable APIE statically >for the guest. > b) Only use KVM_S390_VM_CRYPTO_ENABLE_APIE to indicate/enable APIE >dynamically. > > Both things will be simple

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 3/6] s390x/kvm: enable/disable AP instruction interpretation for guest

2018-09-19 Thread David Hildenbrand
>> >> Apart from that, looks good to me. > > Let me summarize what I think you are suggesting. > > For KVM: > 1. Get rid of KVM_S390_VM_CPU_FEAT_AP in KVM > 2. Make AP instruction interception the default. > 3. Provide the KVM_S390_VM_CRYPTO_ENABLE_APIE attribute in KVM if the > AP

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 3/6] s390x/kvm: enable/disable AP instruction interpretation for guest

2018-09-19 Thread David Hildenbrand
Am 19.09.18 um 00:23 schrieb Halil Pasic: > > > On 09/18/2018 06:59 PM, Tony Krowiak wrote: >> I've discussed this with Halil -- Pierre is out until next week. We >> are in agreement that while these changes are viable, they result in >> a slightly more complicated implementation compared to 

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 3/6] s390x/kvm: enable/disable AP instruction interpretation for guest

2018-09-18 Thread Halil Pasic
On 09/18/2018 06:59 PM, Tony Krowiak wrote: > I've discussed this with Halil -- Pierre is out until next week. We > are in agreement that while these changes are viable, they result in > a slightly more complicated implementation compared to previous versions (e.g. > kernel v9 QEMU v7), and 

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 3/6] s390x/kvm: enable/disable AP instruction interpretation for guest

2018-09-18 Thread Tony Krowiak
On 09/17/2018 04:43 AM, David Hildenbrand wrote: Am 12.09.18 um 22:08 schrieb Tony Krowiak: From: Tony Krowiak Let's use the KVM_SET_DEVICE_ATTR ioctl to enable or disable hardware interpretation of AP instructions executed on the guest. If the S390_FEAT_AP feature is installed, AP

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 3/6] s390x/kvm: enable/disable AP instruction interpretation for guest

2018-09-17 Thread David Hildenbrand
Am 12.09.18 um 22:08 schrieb Tony Krowiak: > From: Tony Krowiak > > Let's use the KVM_SET_DEVICE_ATTR ioctl to enable or disable > hardware interpretation of AP instructions executed on the guest. > If the S390_FEAT_AP feature is installed, AP instructions will > be interpreted by default;

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 3/6] s390x/kvm: enable/disable AP instruction interpretation for guest

2018-09-13 Thread Tony Krowiak
On 09/13/2018 01:28 AM, Thomas Huth wrote: On 2018-09-12 22:08, Tony Krowiak wrote: From: Tony Krowiak Let's use the KVM_SET_DEVICE_ATTR ioctl to enable or disable hardware interpretation of AP instructions executed on the guest. If the S390_FEAT_AP feature is installed, AP instructions will

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 3/6] s390x/kvm: enable/disable AP instruction interpretation for guest

2018-09-12 Thread Thomas Huth
On 2018-09-12 22:08, Tony Krowiak wrote: > From: Tony Krowiak > > Let's use the KVM_SET_DEVICE_ATTR ioctl to enable or disable > hardware interpretation of AP instructions executed on the guest. > If the S390_FEAT_AP feature is installed, AP instructions will > be interpreted by default;