Re: [Qemu-devel] [qemu PATCH v4 0/4] support NFIT platform capabilities

2018-05-31 Thread Elliott, Robert (Persistent Memory)
> Ping on this series. Rob, I think I've addressed all your feedback. > Can you please verify? I haven't tested it, but it reads OK. I'm OK with just extending the valid count for bits set to one for now; we can add a new argument later if a need arises for extending it to express new bits set t

Re: [Qemu-devel] [qemu PATCH v4 0/4] support NFIT platform capabilities

2018-05-31 Thread Ross Zwisler
On Fri, May 25, 2018 at 08:51:22PM +0300, Michael S. Tsirkin wrote: > On Mon, May 21, 2018 at 10:31:59AM -0600, Ross Zwisler wrote: > > Changes since v3: > > * Updated the text in docs/nvdimm.txt to make it clear that the value > >being passed in on the command line in an integer made up of va

Re: [Qemu-devel] [qemu PATCH v4 0/4] support NFIT platform capabilities

2018-05-29 Thread Ross Zwisler
Ping on this series. Rob, I think I've addressed all your feedback. Can you please verify? Thanks, - Ross On Mon, May 21, 2018 at 10:31:59AM -0600, Ross Zwisler wrote: > Changes since v3: > * Updated the text in docs/nvdimm.txt to make it clear that the value >being passed in on the comman

Re: [Qemu-devel] [qemu PATCH v4 0/4] support NFIT platform capabilities

2018-05-25 Thread Michael S. Tsirkin
On Mon, May 21, 2018 at 10:31:59AM -0600, Ross Zwisler wrote: > Changes since v3: > * Updated the text in docs/nvdimm.txt to make it clear that the value >being passed in on the command line in an integer made up of various >bit fields. (Rob Elliott) > > * Updated the "Highest Valid Cap

[Qemu-devel] [qemu PATCH v4 0/4] support NFIT platform capabilities

2018-05-21 Thread Ross Zwisler
Changes since v3: * Updated the text in docs/nvdimm.txt to make it clear that the value being passed in on the command line in an integer made up of various bit fields. (Rob Elliott) * Updated the "Highest Valid Capability" byte to be dynamic based on the highest valid bit in the user'