Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-08-04 Thread Chen, Tiejun
On 2014/7/31 17:53, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:10, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 02:31:36PM +0800, Tiejun Chen wrote: We'd like to split i440fx_init and then we can share something with other stuff

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Chen, Tiejun
On 2014/7/31 23:47, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 08:10:53PM +0800, Chen, Tiejun wrote: On 2014/7/31 18:12, Chen, Tiejun wrote: On 2014/7/31 17:53, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:10, Michael S. Tsirki

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Chen, Tiejun
On 2014/7/31 23:44, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 06:12:32PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:53, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:10, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 02:31:3

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Michael S. Tsirkin
On Thu, Jul 31, 2014 at 08:10:53PM +0800, Chen, Tiejun wrote: > On 2014/7/31 18:12, Chen, Tiejun wrote: > >On 2014/7/31 17:53, Michael S. Tsirkin wrote: > >>On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: > >>>On 2014/7/31 17:10, Michael S. Tsirkin wrote: > On Thu, Jul 31, 2014 at

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Michael S. Tsirkin
On Thu, Jul 31, 2014 at 06:12:32PM +0800, Chen, Tiejun wrote: > On 2014/7/31 17:53, Michael S. Tsirkin wrote: > >On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: > >>On 2014/7/31 17:10, Michael S. Tsirkin wrote: > >>>On Thu, Jul 31, 2014 at 02:31:36PM +0800, Tiejun Chen wrote: > We

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Chen, Tiejun
On 2014/7/31 18:12, Chen, Tiejun wrote: On 2014/7/31 17:53, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:10, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 02:31:36PM +0800, Tiejun Chen wrote: We'd like to split i440fx_init and the

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Chen, Tiejun
On 2014/7/31 17:53, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:10, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 02:31:36PM +0800, Tiejun Chen wrote: We'd like to split i440fx_init and then we can share something with other stuff

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Michael S. Tsirkin
On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: > On 2014/7/31 17:10, Michael S. Tsirkin wrote: > >On Thu, Jul 31, 2014 at 02:31:36PM +0800, Tiejun Chen wrote: > >>We'd like to split i440fx_init and then we can share something > >>with other stuff. > >> > >>Signed-off-by: Tiejun Chen

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Chen, Tiejun
On 2014/7/31 17:10, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 02:31:36PM +0800, Tiejun Chen wrote: We'd like to split i440fx_init and then we can share something with other stuff. Signed-off-by: Tiejun Chen I think this is too much work for very little benefit. Just pass const char *

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Michael S. Tsirkin
On Thu, Jul 31, 2014 at 02:31:36PM +0800, Tiejun Chen wrote: > We'd like to split i440fx_init and then we can share something > with other stuff. > > Signed-off-by: Tiejun Chen I think this is too much work for very little benefit. Just pass const char *type to i440fx_init. --> i440fx: make ty

[Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-30 Thread Tiejun Chen
We'd like to split i440fx_init and then we can share something with other stuff. Signed-off-by: Tiejun Chen --- hw/pci-host/piix.c | 91 -- 1 file changed, 75 insertions(+), 16 deletions(-) v2: * New patch to separate i440fx_init diff --git