Re: [Qemu-devel] [virtio-dev] Re: [v21 1/2] virtio-crypto: Add virtio crypto device specification

2017-11-13 Thread Gonglei (Arei)
Hello Halil, Thanks for your feedback. > > On 11/13/2017 08:17 AM, Gonglei (Arei) wrote: > >>> +struct virtio_crypto_cipher_session_req { > >>> +/* Device-readable part */ > >>> +struct virtio_crypto_cipher_session_para para; > >>> +/* The cipher key */ > >>> +u8 cipher_key[keyl

Re: [Qemu-devel] [virtio-dev] Re: [v21 1/2] virtio-crypto: Add virtio crypto device specification

2017-11-13 Thread Halil Pasic
On 11/13/2017 08:17 AM, Gonglei (Arei) wrote: >>> +struct virtio_crypto_cipher_session_req { >>> +/* Device-readable part */ >>> +struct virtio_crypto_cipher_session_para para; >>> +/* The cipher key */ >>> +u8 cipher_key[keylen]; >>> + >> Is there a limit to the size of chiper_ke

Re: [Qemu-devel] [virtio-dev] Re: [v21 1/2] virtio-crypto: Add virtio crypto device specification

2017-11-12 Thread Gonglei (Arei)
Hi, > > > +The controlq request is composed of two parts: > > +\begin{lstlisting} > > +struct virtio_crypto_op_ctrl_req { > > +struct virtio_crypto_ctrl_header header; > > + > > +/* additional paramenter */ > > +u8 additional_para[addl_para_len]; > > What does additional paramenter me