Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 12:39, Marcel Apfelbaum ha scritto: > Thanks! > That means that hpev_intx is not necessary at all. > By the way, aer_intx used by Advanced Error Reporting > is also unnecessary. (6.2.4.1.2 has the same note) > > I will remove the above fields from PCIExpressDevice. vmxnet is also bu

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Marcel Apfelbaum
On Mon, 2013-09-30 at 13:10 +0300, Michael S. Tsirkin wrote: > On Mon, Sep 30, 2013 at 12:43:20PM +0300, Marcel Apfelbaum wrote: > > On Mon, 2013-09-30 at 12:14 +0300, Michael S. Tsirkin wrote: > > > On Mon, Sep 30, 2013 at 11:02:06AM +0200, Paolo Bonzini wrote: > > > > Il 30/09/2013 10:58, Michael

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 12:43:20PM +0300, Marcel Apfelbaum wrote: > On Mon, 2013-09-30 at 12:14 +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 30, 2013 at 11:02:06AM +0200, Paolo Bonzini wrote: > > > Il 30/09/2013 10:58, Michael S. Tsirkin ha scritto: > > > >>> > > As a next step, can we make pci

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Marcel Apfelbaum
On Mon, 2013-09-30 at 12:14 +0300, Michael S. Tsirkin wrote: > On Mon, Sep 30, 2013 at 11:02:06AM +0200, Paolo Bonzini wrote: > > Il 30/09/2013 10:58, Michael S. Tsirkin ha scritto: > > >>> > > As a next step, can we make pci_set_irq non-inline and make > > >>> > > it call pci_irq_handler directly,

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 11:02:06AM +0200, Paolo Bonzini wrote: > Il 30/09/2013 10:58, Michael S. Tsirkin ha scritto: > >>> > > As a next step, can we make pci_set_irq non-inline and make > >>> > > it call pci_irq_handler directly, and get rid of the irq field? > >> > What irq field? > > /* IRQ

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 10:58, Michael S. Tsirkin ha scritto: >>> > > As a next step, can we make pci_set_irq non-inline and make >>> > > it call pci_irq_handler directly, and get rid of the irq field? >> > What irq field? > /* IRQ objects for the INTA-INTD pins. */ > qemu_irq *irq; > That's stil

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 11:14:56AM +0300, Marcel Apfelbaum wrote: > On Sun, 2013-09-29 at 18:06 +0300, Michael S. Tsirkin wrote: > > On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote: > > > Interrupt pin is selected and saved into PCI_INTERRUPT_PIN > > > register during device initia

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-30 Thread Marcel Apfelbaum
On Sun, 2013-09-29 at 18:06 +0300, Michael S. Tsirkin wrote: > On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote: > > Interrupt pin is selected and saved into PCI_INTERRUPT_PIN > > register during device initialization. Devices should not call > > directly qemu_set_irq and specify th

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-29 Thread Michael S. Tsirkin
On Sun, Sep 29, 2013 at 06:24:48PM +0300, Marcel Apfelbaum wrote: > removed addresses: > av1...@comtv.ru > p...@codesourcery.com > > > On Sun, 2013-09-29 at 18:06 +0300, Michael S. Tsirkin wrote: > > On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote: > > > Interrupt pin is selected

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-29 Thread Marcel Apfelbaum
removed addresses: av1...@comtv.ru p...@codesourcery.com On Sun, 2013-09-29 at 18:06 +0300, Michael S. Tsirkin wrote: > On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote: > > Interrupt pin is selected and saved into PCI_INTERRUPT_PIN > > register during device initialization. Devic

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-29 Thread Michael S. Tsirkin
On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote: > Interrupt pin is selected and saved into PCI_INTERRUPT_PIN > register during device initialization. Devices should not call > directly qemu_set_irq and specify the INTx pin. > > Replaced the call to qemu_set_irq with a new wrapper

[Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-29 Thread Marcel Apfelbaum
Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin. Replaced the call to qemu_set_irq with a new wrapper pci_set_irq which triggers the irq based on PCI_INTERRUPT_PIN. Marcel Apfe