Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-03-15 Thread Daniel P . Berrangé
On Fri, Mar 15, 2019 at 03:51:57PM +, Singh, Brijesh wrote: > Hi Daniel, > > > On 3/15/19 7:18 AM, Daniel P. Berrangé wrote: > > On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote: > >> > >> On 1/18/19 3:39 AM, Erik Skultety wrote: > >>> I proceeded with cloning [1] to systemd and

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-03-15 Thread Singh, Brijesh
Hi Daniel, On 3/15/19 7:18 AM, Daniel P. Berrangé wrote: > On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote: >> >> On 1/18/19 3:39 AM, Erik Skultety wrote: >>> I proceeded with cloning [1] to systemd and creating an udev rule that I >>> planned >>> on submitting to systemd upstream

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-03-15 Thread Daniel P . Berrangé
On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote: > > On 1/18/19 3:39 AM, Erik Skultety wrote: > > I proceeded with cloning [1] to systemd and creating an udev rule that I > > planned > > on submitting to systemd upstream - the initial idea was to mimic /dev/kvm > > and > > make it

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-31 Thread Erik Skultety
On Wed, Jan 30, 2019 at 06:18:22PM +, Daniel P. Berrangé wrote: > On Wed, Jan 30, 2019 at 02:39:54PM +0100, Erik Skultety wrote: > > > > > though, we need a #ifdef check for existance of PR_CAP_AMBIENT > > > > > > > > > > > An alternative question I've been playing ever since we exchanged > >

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-30 Thread Daniel P . Berrangé
On Wed, Jan 30, 2019 at 02:39:54PM +0100, Erik Skultety wrote: > > > > though, we need a #ifdef check for existance of PR_CAP_AMBIENT > > > > > > > > > An alternative question I've been playing ever since we exchanged the > > > > > last few > > > > > emails is that can't we wait until the ioctls a

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-30 Thread Singh, Brijesh
On 1/30/19 7:39 AM, Erik Skultety wrote: though, we need a #ifdef check for existance of PR_CAP_AMBIENT > An alternative question I've been playing ever since we exchanged the > last few > emails is that can't we wait until the ioctls are compared against > permissions

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-30 Thread Erik Skultety
> > > though, we need a #ifdef check for existance of PR_CAP_AMBIENT > > > > > > > An alternative question I've been playing ever since we exchanged the > > > > last few > > > > emails is that can't we wait until the ioctls are compared against > > > > permissions > > > > in kernel so that upstre

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-30 Thread Daniel P . Berrangé
On Wed, Jan 30, 2019 at 09:06:30AM +0100, Erik Skultety wrote: > Thanks for ^this bit which helped me understand the bits below. When I read > the > man page yesterday the first question was, okay, how do I figure out whether > the file capabilities bit is set? Well, use xattrs...which didn't retu

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-30 Thread Erik Skultety
On Tue, Jan 29, 2019 at 06:40:08PM +, Daniel P. Berrangé wrote: > On Tue, Jan 29, 2019 at 05:15:42PM +0100, Erik Skultety wrote: > > On Wed, Jan 23, 2019 at 03:02:28PM +, Singh, Brijesh wrote: > > > > > > > > > On 1/23/19 7:36 AM, Daniel P. Berrangé wrote: > > > > On Wed, Jan 23, 2019 at 02

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-29 Thread Daniel P . Berrangé
On Tue, Jan 29, 2019 at 05:15:42PM +0100, Erik Skultety wrote: > On Wed, Jan 23, 2019 at 03:02:28PM +, Singh, Brijesh wrote: > > > > > > On 1/23/19 7:36 AM, Daniel P. Berrangé wrote: > > > On Wed, Jan 23, 2019 at 02:33:01PM +0100, Erik Skultety wrote: > > >> On Wed, Jan 23, 2019 at 01:24:13PM +

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-29 Thread Erik Skultety
On Wed, Jan 23, 2019 at 03:02:28PM +, Singh, Brijesh wrote: > > > On 1/23/19 7:36 AM, Daniel P. Berrangé wrote: > > On Wed, Jan 23, 2019 at 02:33:01PM +0100, Erik Skultety wrote: > >> On Wed, Jan 23, 2019 at 01:24:13PM +, Daniel P. Berrangé wrote: > >>> On Wed, Jan 23, 2019 at 02:22:12PM +0

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-23 Thread Erik Skultety
On Wed, Jan 23, 2019 at 03:02:28PM +, Singh, Brijesh wrote: > > > On 1/23/19 7:36 AM, Daniel P. Berrangé wrote: > > On Wed, Jan 23, 2019 at 02:33:01PM +0100, Erik Skultety wrote: > >> On Wed, Jan 23, 2019 at 01:24:13PM +, Daniel P. Berrangé wrote: > >>> On Wed, Jan 23, 2019 at 02:22:12PM +0

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-23 Thread Singh, Brijesh
On 1/23/19 7:36 AM, Daniel P. Berrangé wrote: > On Wed, Jan 23, 2019 at 02:33:01PM +0100, Erik Skultety wrote: >> On Wed, Jan 23, 2019 at 01:24:13PM +, Daniel P. Berrangé wrote: >>> On Wed, Jan 23, 2019 at 02:22:12PM +0100, Erik Skultety wrote: On Wed, Jan 23, 2019 at 01:10:42PM +, D

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-23 Thread Daniel P . Berrangé
On Wed, Jan 23, 2019 at 02:33:01PM +0100, Erik Skultety wrote: > On Wed, Jan 23, 2019 at 01:24:13PM +, Daniel P. Berrangé wrote: > > On Wed, Jan 23, 2019 at 02:22:12PM +0100, Erik Skultety wrote: > > > On Wed, Jan 23, 2019 at 01:10:42PM +, Daniel P. Berrangé wrote: > > > > On Wed, Jan 23, 2

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-23 Thread Erik Skultety
On Wed, Jan 23, 2019 at 01:24:13PM +, Daniel P. Berrangé wrote: > On Wed, Jan 23, 2019 at 02:22:12PM +0100, Erik Skultety wrote: > > On Wed, Jan 23, 2019 at 01:10:42PM +, Daniel P. Berrangé wrote: > > > On Wed, Jan 23, 2019 at 01:55:06PM +0100, Erik Skultety wrote: > > > > On Fri, Jan 18, 2

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-23 Thread Daniel P . Berrangé
On Wed, Jan 23, 2019 at 01:55:06PM +0100, Erik Skultety wrote: > On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote: > > > > On 1/18/19 3:39 AM, Erik Skultety wrote: > > > Hi, > > > this is a summary of a private discussion I've had with guys CC'd on this > > > email > > > about findin

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-23 Thread Erik Skultety
On Wed, Jan 23, 2019 at 01:10:42PM +, Daniel P. Berrangé wrote: > On Wed, Jan 23, 2019 at 01:55:06PM +0100, Erik Skultety wrote: > > On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote: > > > > > > On 1/18/19 3:39 AM, Erik Skultety wrote: > > > > Hi, > > > > this is a summary of a pr

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-23 Thread Daniel P . Berrangé
On Wed, Jan 23, 2019 at 02:22:12PM +0100, Erik Skultety wrote: > On Wed, Jan 23, 2019 at 01:10:42PM +, Daniel P. Berrangé wrote: > > On Wed, Jan 23, 2019 at 01:55:06PM +0100, Erik Skultety wrote: > > > On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote: > > > > > > > > On 1/18/19 3:

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-23 Thread Erik Skultety
On Fri, Jan 18, 2019 at 12:51:50PM +, Singh, Brijesh wrote: > > On 1/18/19 3:39 AM, Erik Skultety wrote: > > Hi, > > this is a summary of a private discussion I've had with guys CC'd on this > > email > > about finding a solution to [1] - basically, the default permissions on > > /dev/sev (bel

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-18 Thread Martin Kletzander
On Fri, Jan 18, 2019 at 10:16:38AM +, Daniel P. Berrangé wrote: On Fri, Jan 18, 2019 at 10:39:35AM +0100, Erik Skultety wrote: Hi, this is a summary of a private discussion I've had with guys CC'd on this email about finding a solution to [1] - basically, the default permissions on /dev/sev

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-18 Thread Martin Kletzander
On Fri, Jan 18, 2019 at 11:17:11AM +, Daniel P. Berrangé wrote: On Fri, Jan 18, 2019 at 12:11:50PM +0100, Martin Kletzander wrote: On Fri, Jan 18, 2019 at 10:16:38AM +, Daniel P. Berrangé wrote: > I've just realized there is a potential 3rd solution. Remember there is > actually nothing

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-18 Thread Singh, Brijesh
On 1/18/19 3:39 AM, Erik Skultety wrote: > Hi, > this is a summary of a private discussion I've had with guys CC'd on this > email > about finding a solution to [1] - basically, the default permissions on > /dev/sev (below) make it impossible to query for SEV platform capabilities, > since by def

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-18 Thread Daniel P . Berrangé
On Fri, Jan 18, 2019 at 12:11:50PM +0100, Martin Kletzander wrote: > On Fri, Jan 18, 2019 at 10:16:38AM +, Daniel P. Berrangé wrote: > > I've just realized there is a potential 3rd solution. Remember there is > > actually nothing inherantly special about the 'root' user as an account > > ID. 'r

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-18 Thread Daniel P . Berrangé
On Fri, Jan 18, 2019 at 10:39:35AM +0100, Erik Skultety wrote: > Hi, > this is a summary of a private discussion I've had with guys CC'd on this > email > about finding a solution to [1] - basically, the default permissions on > /dev/sev (below) make it impossible to query for SEV platform capabil

[Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-18 Thread Erik Skultety
Hi, this is a summary of a private discussion I've had with guys CC'd on this email about finding a solution to [1] - basically, the default permissions on /dev/sev (below) make it impossible to query for SEV platform capabilities, since by default we run QEMU as qemu:qemu when probing for capabili