[Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Varad Gautam
Hi! I'm new here, and am working on my first bug. I have posted a patch for Bug#603872 [1] to the list.. It's incomplete right now, but please have a look and tell me if I'm headed in the right direction. (I don't know if I can send incomplete patches to the mailing list for suggestions or if I

[Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Varad Gautam
Hi! I'm new here, and am working on my first bug. I have posted a patch for Bug#603872 [1] to the list.. It's incomplete right now, but please have a look and tell me if I'm headed in the right direction. (I don't know if I can send incomplete patches to the mailing list for suggestions or if I

Re: [Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Varad Gautam
To discuss the code you really should post the patch, I couldn't find any related code by your link. Hi! I had posted the patch onto the list. I have also put it at [1] now. Thanks. Varad [1] https://bugs.launchpad.net/qemu/+bug/603872

Re: [Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Andreas Färber
Am 18.11.2013 16:59, schrieb Varad Gautam: To discuss the code you really should post the patch, I couldn't find any related code by your link. Hi! I had posted the patch onto the list. Unfortunately several copies of your mail arrived on the list today, and only one actually has the patch

Re: [Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Eric Blake
On 11/18/2013 09:45 AM, Andreas Färber wrote: Am 18.11.2013 16:59, schrieb Varad Gautam: To discuss the code you really should post the patch, I couldn't find any related code by your link. Hi! I had posted the patch onto the list. Unfortunately several copies of your mail arrived on the

Re: [Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Varad Gautam
On Mon, Nov 18, 2013 at 10:31 PM, Eric Blake ebl...@redhat.com wrote: Often-times, this happens when a new contributor fails to realize that the list is moderated, but that we will moderate non-subscriber's messages through. What commonly happens is that a new contributor sends a message,

Re: [Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Eric Blake
On 11/18/2013 11:41 AM, Varad Gautam wrote: On Mon, Nov 18, 2013 at 10:31 PM, Eric Blake ebl...@redhat.com wrote: Varad, as a new contributor, you are in a position to possibly help us: what documentation pages did you read to learn where to post your patches, so that we can try and modify