Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-27 Thread Eduardo Habkost
On Mon, May 27, 2019 at 06:29:44PM +0200, Andrea Bolognani wrote: > On Fri, 2019-05-24 at 15:24 -0300, Eduardo Habkost wrote: > > On Thu, May 23, 2019 at 10:35:24AM +0200, Andrea Bolognani wrote: > > > [...] the above looks good to > > > me as a general direction, but note that you'll have to imple

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-27 Thread Andrea Bolognani
On Fri, 2019-05-24 at 15:24 -0300, Eduardo Habkost wrote: > On Thu, May 23, 2019 at 10:35:24AM +0200, Andrea Bolognani wrote: > > [...] the above looks good to > > me as a general direction, but note that you'll have to implement at > > the very least the query-cpu-model-expansion QMP command for t

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-24 Thread Eduardo Habkost
On Thu, May 23, 2019 at 10:35:24AM +0200, Andrea Bolognani wrote: > On Wed, 2019-05-15 at 13:54 +0200, Andrew Jones wrote: > > On Wed, May 15, 2019 at 12:52:29PM +0200, Igor Mammedov wrote: > > > since using magic numbers is not very descriptive > > > (but if there is some spec where they come from

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-23 Thread Andrea Bolognani
On Wed, 2019-05-15 at 13:54 +0200, Andrew Jones wrote: > On Wed, May 15, 2019 at 12:52:29PM +0200, Igor Mammedov wrote: > > since using magic numbers is not very descriptive > > (but if there is some spec where they come from that we could point users to > > it might be acceptable too, but I'd rese

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 12:09:04PM +0100, Dr. David Alan Gilbert wrote: > * Dave Martin (dave.mar...@arm.com) wrote: > > On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > > On Tue, 14 May 2019 11:02:25 +0200 > >

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 12:42:44PM +0100, Andrew Jones wrote: > On Wed, May 15, 2019 at 12:00:45PM +0100, Dave Martin wrote: > > On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > > On Tue, 14 May 2019 11:02:25 +0

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Andrew Jones
On Wed, May 15, 2019 at 12:52:29PM +0200, Igor Mammedov wrote: > On Wed, 15 May 2019 10:18:54 +0200 > Andrew Jones wrote: > > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > On Tue, 14 May 2019 11:02:25 +0200 > > > Andrew Jones wrote: > > > > My thought is primarily mach

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Andrew Jones
On Wed, May 15, 2019 at 12:00:45PM +0100, Dave Martin wrote: > On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > On Tue, 14 May 2019 11:02:25 +0200 > > > Andrew Jones wrote: > > > > My thought is primarily machine

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dr. David Alan Gilbert
* Dave Martin (dave.mar...@arm.com) wrote: > On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > > On Tue, 14 May 2019 11:02:25 +0200 > > > Andrew Jones wrote: > > > > My thought is primarily machines. If a human want

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 09:18:54AM +0100, Andrew Jones wrote: > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > On Tue, 14 May 2019 11:02:25 +0200 > > Andrew Jones wrote: > > > My thought is primarily machines. If a human wants to use the command > > > line and SVE, then I'm ass

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dr. David Alan Gilbert
* Dave Martin (dave.mar...@arm.com) wrote: > On Wed, May 15, 2019 at 09:15:20AM +0100, Andrew Jones wrote: > > On Tue, May 14, 2019 at 03:32:13PM +0200, Markus Armbruster wrote: > > > Syntax that can support such growth would be nice. > > > > > > To grow a single unsigned number, we can make it wi

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Igor Mammedov
On Wed, 15 May 2019 10:18:54 +0200 Andrew Jones wrote: > On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > > On Tue, 14 May 2019 11:02:25 +0200 > > Andrew Jones wrote: > > > My thought is primarily machines. If a human wants to use the command > > > line and SVE, then I'm assumi

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Dave Martin
On Wed, May 15, 2019 at 09:15:20AM +0100, Andrew Jones wrote: > On Tue, May 14, 2019 at 03:32:13PM +0200, Markus Armbruster wrote: > > Syntax that can support such growth would be nice. > > > > To grow a single unsigned number, we can make it wider (but we don't > > have infrastructure for numbers

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Andrew Jones
On Tue, May 14, 2019 at 04:48:38PM +0200, Igor Mammedov wrote: > On Tue, 14 May 2019 11:02:25 +0200 > Andrew Jones wrote: > > My thought is primarily machines. If a human wants to use the command > > line and SVE, then I'm assuming they'll be happy with sve-max-vq or > > figuring out a map they li

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-15 Thread Andrew Jones
On Tue, May 14, 2019 at 03:32:13PM +0200, Markus Armbruster wrote: > Syntax that can support such growth would be nice. > > To grow a single unsigned number, we can make it wider (but we don't > have infrastructure for numbers wider than 64 bits), or we can add more > numbers (but under what name?

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-14 Thread Dave Martin
On Tue, May 14, 2019 at 05:54:03AM +0100, Markus Armbruster wrote: > Andrew Jones writes: > > > On Thu, Apr 18, 2019 at 07:48:09PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: > >> >> Hi all, > >> >> >

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-14 Thread Igor Mammedov
On Tue, 14 May 2019 11:02:25 +0200 Andrew Jones wrote: > On Tue, May 14, 2019 at 06:54:03AM +0200, Markus Armbruster wrote: > > Andrew Jones writes: > > > > > On Thu, Apr 18, 2019 at 07:48:09PM +0200, Markus Armbruster wrote: > > >> Daniel P. Berrangé writes: > > >> > > >> > On Thu, Apr 18, 2

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-14 Thread Markus Armbruster
Andrew Jones writes: > On Tue, May 14, 2019 at 06:54:03AM +0200, Markus Armbruster wrote: >> Andrew Jones writes: >> >> > On Thu, Apr 18, 2019 at 07:48:09PM +0200, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wr

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-14 Thread Andrew Jones
On Tue, May 14, 2019 at 06:54:03AM +0200, Markus Armbruster wrote: > Andrew Jones writes: > > > On Thu, Apr 18, 2019 at 07:48:09PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: > >> >> Hi all, > >> >> >

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-13 Thread Markus Armbruster
Andrew Jones writes: > On Thu, Apr 18, 2019 at 07:48:09PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: >> >> Hi all, >> >> >> >> First some background: >> >> >> >> For the userspace side of AArch64 guest SV

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-13 Thread Andrew Jones
On Thu, Apr 18, 2019 at 07:48:09PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: > >> Hi all, > >> > >> First some background: > >> > >> For the userspace side of AArch64 guest SVE support we need to > >> expose

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-04-18 Thread Laszlo Ersek
On 04/18/19 11:28, Andrew Jones wrote: > Hi all, > > First some background: > > For the userspace side of AArch64 guest SVE support we need to > expose KVM's allowed vector lengths bitmap to the user and allow > the user to choose a subset of that bitmap. Since bitmaps are a > bit awkward to work

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-04-18 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: >> Hi all, >> >> First some background: >> >> For the userspace side of AArch64 guest SVE support we need to >> expose KVM's allowed vector lengths bitmap to the user and allow >> the user to choose a sub

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-04-18 Thread Andrew Jones
On Thu, Apr 18, 2019 at 12:26:10PM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: > > Hi all, > > > > First some background: > > > > For the userspace side of AArch64 guest SVE support we need to > > expose KVM's allowed vector lengths bitmap to t

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-04-18 Thread Dave Martin
On Thu, Apr 18, 2019 at 03:43:06PM +0100, Andrew Jones wrote: > On Thu, Apr 18, 2019 at 03:03:02PM +0100, Dave Martin wrote: [...] > > It's worth nothing that there are two problems to be solved here: one is > > to specify an exact set unambiguously, which is important for migration > > scenarios

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-04-18 Thread Andrew Jones
On Thu, Apr 18, 2019 at 03:03:02PM +0100, Dave Martin wrote: > On Thu, Apr 18, 2019 at 12:28:47PM +0100, Andrew Jones wrote: > > On Thu, Apr 18, 2019 at 11:52:04AM +0100, Dave Martin wrote: > > > On Thu, Apr 18, 2019 at 10:46:34AM +0100, Andrew Jones wrote: > > > > On Thu, Apr 18, 2019 at 11:28:41A

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-04-18 Thread Dr. David Alan Gilbert
* Andrew Jones (drjo...@redhat.com) wrote: > On Thu, Apr 18, 2019 at 03:03:02PM +0100, Dave Martin wrote: > > On Thu, Apr 18, 2019 at 12:28:47PM +0100, Andrew Jones wrote: > > > On Thu, Apr 18, 2019 at 11:52:04AM +0100, Dave Martin wrote: > > > > On Thu, Apr 18, 2019 at 10:46:34AM +0100, Andrew Jon

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-04-18 Thread Dave Martin
On Thu, Apr 18, 2019 at 12:28:47PM +0100, Andrew Jones wrote: > On Thu, Apr 18, 2019 at 11:52:04AM +0100, Dave Martin wrote: > > On Thu, Apr 18, 2019 at 10:46:34AM +0100, Andrew Jones wrote: > > > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: > > > > Hi all, > > > > > > > > First s

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-04-18 Thread Andrew Jones
On Thu, Apr 18, 2019 at 11:52:04AM +0100, Dave Martin wrote: > On Thu, Apr 18, 2019 at 10:46:34AM +0100, Andrew Jones wrote: > > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: > > > Hi all, > > > > > > First some background: > > > > > > For the userspace side of AArch64 guest SVE s

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-04-18 Thread Daniel P . Berrangé
On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: > Hi all, > > First some background: > > For the userspace side of AArch64 guest SVE support we need to > expose KVM's allowed vector lengths bitmap to the user and allow > the user to choose a subset of that bitmap. Since bitmaps are

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-04-18 Thread Dave Martin
On Thu, Apr 18, 2019 at 10:46:34AM +0100, Andrew Jones wrote: > On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: > > Hi all, > > > > First some background: > > > > For the userspace side of AArch64 guest SVE support we need to > > expose KVM's allowed vector lengths bitmap to the use

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-04-18 Thread Andrew Jones
On Thu, Apr 18, 2019 at 11:28:41AM +0200, Andrew Jones wrote: > Hi all, > > First some background: > > For the userspace side of AArch64 guest SVE support we need to > expose KVM's allowed vector lengths bitmap to the user and allow > the user to choose a subset of that bitmap. Since bitmaps are

[Qemu-devel] How do we do user input bitmap properties?

2019-04-18 Thread Andrew Jones
Hi all, First some background: For the userspace side of AArch64 guest SVE support we need to expose KVM's allowed vector lengths bitmap to the user and allow the user to choose a subset of that bitmap. Since bitmaps are a bit awkward to work with then we'll likely want to expose it as an array o