Re: [Qemu-devel] PATCH: ide.c: send irq for WIN_DIAGNOSE

2007-12-10 Thread Tristan Gingold
Index: hw/ide.c === RCS file: /sources/qemu/qemu/hw/ide.c,v retrieving revision 1.72 diff -u -r1.72 ide.c --- hw/ide.c18 Nov 2007 01:44:37 - 1.72 +++ hw/ide.c30 Nov 2007 14:02:33 - @@ -2042,6 +2053,7 @@

Re: [Qemu-devel] PATCH: ide.c: send irq for WIN_DIAGNOSE

2007-12-03 Thread Tristan Gingold
On Nov 30, 2007, at 3:12 PM, Carlo Marcelo Arenas Belon wrote: right my bad, missed that on my copy of ATA-4 while looking for a match to your description of the mis-implementation, but why are you asserting one also for the reset? My fault. I tried to make code common too quickly! If I

Re: [Qemu-devel] PATCH: ide.c: send irq for WIN_DIAGNOSE

2007-11-30 Thread Carlo Marcelo Arenas Belon
On Thu, Nov 29, 2007 at 05:46:08PM +0100, Tristan Gingold wrote: > On Nov 29, 2007, at 4:07 PM, Carlo Marcelo Arenas Belon wrote: > >On Thu, Nov 29, 2007 at 02:05:36PM +0100, Tristan Gingold wrote: > > >> The pending interrupt condition shall be set by: > >> ??? the completion of a command; or >

Re: [Qemu-devel] PATCH: ide.c: send irq for WIN_DIAGNOSE

2007-11-29 Thread Tristan Gingold
On Nov 29, 2007, at 4:07 PM, Carlo Marcelo Arenas Belon wrote: On Thu, Nov 29, 2007 at 02:05:36PM +0100, Tristan Gingold wrote: according to ATA std: which ATA std? A rather old one: ATA-3 The pending interrupt condition shall be set by: ??? the completion of a command; or This patc

Re: [Qemu-devel] PATCH: ide.c: send irq for WIN_DIAGNOSE

2007-11-29 Thread Carlo Marcelo Arenas Belon
On Thu, Nov 29, 2007 at 02:05:36PM +0100, Tristan Gingold wrote: > according to ATA std: which ATA std? > The pending interrupt condition shall be set by: > ??? the completion of a command; or > > This patch sends an irq for WIN_DIAGNOSE (and WIN_SRST) DEVICE RESET or DEVICE DIAGNOSTIC in T

[Qemu-devel] PATCH: ide.c: send irq for WIN_DIAGNOSE

2007-11-29 Thread Tristan Gingold
Hi, according to ATA std: The pending interrupt condition shall be set by: − the completion of a command; or This patch sends an irq for WIN_DIAGNOSE (and WIN_SRST) Tristan. qemu.diff Description: Binary data