Re: [Qemu-devel] RFC: cleanups: CPU_MEM_INDEX

2007-10-13 Thread J. Mayer
On Fri, 2007-10-12 at 09:01 +0200, J. Mayer wrote: On Thu, 2007-10-11 at 14:09 +0200, J. Mayer wrote: On Wed, 2007-10-10 at 07:06 +0200, J. Mayer wrote: On Wed, 2007-10-10 at 01:12 +0100, Thiemo Seufer wrote: J. Mayer wrote: Here's a proposal to add a int cpu_mem_index (CPUState

Re: [Qemu-devel] RFC: cleanups: CPU_MEM_INDEX

2007-10-13 Thread Thiemo Seufer
J. Mayer wrote: [snip] Other than that it looks good to me (and reminds me to check what the supervisor mode on MIPS actually does now :-). This updated patch gives the opportunity to define a per-target semantic of the mmu_idx... Time to check what it means in actual CPU

Re: [Qemu-devel] RFC: cleanups: CPU_MEM_INDEX

2007-10-11 Thread Thiemo Seufer
J. Mayer wrote: On Wed, 2007-10-10 at 07:06 +0200, J. Mayer wrote: On Wed, 2007-10-10 at 01:12 +0100, Thiemo Seufer wrote: J. Mayer wrote: Here's a proposal to add a int cpu_mem_index (CPUState *env) function in targets cpu.h header. The idea of this patch is: - avoid many

Re: [Qemu-devel] RFC: cleanups: CPU_MEM_INDEX

2007-10-11 Thread J. Mayer
On Thu, 2007-10-11 at 18:46 +0100, Thiemo Seufer wrote: J. Mayer wrote: On Wed, 2007-10-10 at 07:06 +0200, J. Mayer wrote: On Wed, 2007-10-10 at 01:12 +0100, Thiemo Seufer wrote: J. Mayer wrote: Here's a proposal to add a int cpu_mem_index (CPUState *env) function in

[Qemu-devel] RFC: cleanups: CPU_MEM_INDEX

2007-10-09 Thread J. Mayer
Here's a proposal to add a int cpu_mem_index (CPUState *env) function in targets cpu.h header. The idea of this patch is: - avoid many #ifdef TARGET_xxx in exec-all.h and softmmu_header.h then make the code more readable - avoid multiple implementation of the same code (3, in that particular

Re: [Qemu-devel] RFC: cleanups: CPU_MEM_INDEX

2007-10-09 Thread Thiemo Seufer
J. Mayer wrote: Here's a proposal to add a int cpu_mem_index (CPUState *env) function in targets cpu.h header. The idea of this patch is: - avoid many #ifdef TARGET_xxx in exec-all.h and softmmu_header.h then make the code more readable - avoid multiple implementation of the same code (3,