[Qemu-devel] Re: [PATCH] block.h: Make BDRV_SECTOR_SIZE 64 bit safe

2010-05-28 Thread Paolo Bonzini
On 05/27/2010 05:44 PM, Jes Sorensen wrote: Candidate for stable too? It should be safe to apply, but I didn't find any current users where the mask was applied in a way where it was causing problems. Not sure if you want the noise, or apply it as better safe than sorry? The only use in fact

[Qemu-devel] Re: [PATCH] block.h: Make BDRV_SECTOR_SIZE 64 bit safe

2010-05-28 Thread Jes Sorensen
On 05/28/10 10:32, Paolo Bonzini wrote: On 05/27/2010 05:44 PM, Jes Sorensen wrote: Candidate for stable too? It should be safe to apply, but I didn't find any current users where the mask was applied in a way where it was causing problems. Not sure if you want the noise, or apply it as

[Qemu-devel] Re: [PATCH] block.h: Make BDRV_SECTOR_SIZE 64 bit safe

2010-05-27 Thread Paolo Bonzini
On 05/27/2010 04:27 PM, Kevin Wolf wrote: Am 27.05.2010 15:46, schrieb jes.soren...@redhat.com: From: Jes Sorensenjes.soren...@redhat.com C defaults to int, so make definition of BDRV_SECTOR_SIZE 64 bit safe as it and BDRV_SECTOR_MASK may be used against 64 bit addresses. Signed-off-by: Jes

[Qemu-devel] Re: [PATCH] block.h: Make BDRV_SECTOR_SIZE 64 bit safe

2010-05-27 Thread Jes Sorensen
On 05/27/10 17:38, Paolo Bonzini wrote: On 05/27/2010 04:27 PM, Kevin Wolf wrote: Am 27.05.2010 15:46, schrieb jes.soren...@redhat.com: From: Jes Sorensenjes.soren...@redhat.com C defaults to int, so make definition of BDRV_SECTOR_SIZE 64 bit safe as it and BDRV_SECTOR_MASK may be used