On Sun, Jan 16, 2011 at 12:56 PM, Stefan Weil <w...@mail.berlios.de> wrote: > These errors were reported by cppcheck: > > bsd-user/elfload.c:1076: error: Memory leak: s > bsd-user/elfload.c:1079: error: Memory leak: syms > > Cc: Blue Swirl <blauwir...@gmail.com> > Signed-off-by: Stefan Weil <w...@mail.berlios.de> > --- > bsd-user/elfload.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c > index 7374912..313ddc6 100644 > --- a/bsd-user/elfload.c > +++ b/bsd-user/elfload.c > @@ -1072,11 +1072,16 @@ static void load_symbols(struct elfhdr *hdr, int fd) > /* Now know where the strtab and symtab are. Snarf them. */ > s = malloc(sizeof(*s)); > syms = malloc(symtab.sh_size); > - if (!syms) > + if (!syms) {
If we used qemu_malloc(), this wouldn't happen since it will exit if malloc() fails. But is that OK, maybe we want to load the file without symbols then?