[Qemu-devel] Re: [PATCH] qemu: work around for posix-aio-compat

2009-10-21 Thread Michael S. Tsirkin
On Tue, Oct 20, 2009 at 08:57:13PM +0200, Paolo Bonzini wrote: On 10/20/2009 08:39 PM, Mark McLoughlin wrote: On Thu, 2009-10-08 at 22:37 +0200, Michael S. Tsirkin wrote: With commit ee3993069ff55fa6f1c64daf1e09963e340db8e4, posix-aio-compat: avoid signal race when spawning a thread winxp

[Qemu-devel] Re: [PATCH] qemu: work around for posix-aio-compat

2009-10-21 Thread Michael S. Tsirkin
On Wed, Oct 21, 2009 at 05:42:34PM +0200, Michael S. Tsirkin wrote: On Tue, Oct 20, 2009 at 08:57:13PM +0200, Paolo Bonzini wrote: On 10/20/2009 08:39 PM, Mark McLoughlin wrote: On Thu, 2009-10-08 at 22:37 +0200, Michael S. Tsirkin wrote: With commit

[Qemu-devel] Re: [PATCH] qemu: work around for posix-aio-compat

2009-10-21 Thread Paolo Bonzini
I've uploaded them here: http://www.kernel.org/pub/linux/kernel/people/mst/ you can't see them in mirrors yet but will be able to soon when kernel.org mirroring system catches them. There is no difference in optimizations except that here: for (i = 0; i aiocb-aio_niov count; ++i) {

[Qemu-devel] Re: [PATCH] qemu: work around for posix-aio-compat

2009-10-21 Thread Michael S. Tsirkin
On Wed, Oct 21, 2009 at 07:28:54PM +0200, Paolo Bonzini wrote: I've uploaded them here: http://www.kernel.org/pub/linux/kernel/people/mst/ you can't see them in mirrors yet but will be able to soon when kernel.org mirroring system catches them. There is no difference in optimizations except

[Qemu-devel] Re: [PATCH] qemu: work around for posix-aio-compat

2009-10-21 Thread Paolo Bonzini
I suggest trying to make the sigset_t static, since that generates exactly the same code as the nohang case, and exactly the same stack layout as the hang case. (In case this wasn't clear: the sigfillset of a static sigset_t should hang, proving that it's stack layout that comes to the

[Qemu-devel] Re: [PATCH] qemu: work around for posix-aio-compat

2009-10-21 Thread Michael S. Tsirkin
On Wed, Oct 21, 2009 at 07:44:14PM +0200, Paolo Bonzini wrote: I suggest trying to make the sigset_t static, since that generates exactly the same code as the nohang case, and exactly the same stack layout as the hang case. (In case this wasn't clear: the sigfillset of a static sigset_t

[Qemu-devel] Re: [PATCH] qemu: work around for posix-aio-compat

2009-10-21 Thread Paolo Bonzini
At every word of the sigset (using gdb commands to disable/enable the watchpoints around the sigfillset, you avoid spurious triggers). Not sure how do you mean. When would I enable the watchpoint? 301 static void *aio_thread(void *unused) 302 { 303 pid_t pid; 304

[Qemu-devel] Re: [PATCH] qemu: work around for posix-aio-compat

2009-10-20 Thread Paolo Bonzini
On 10/20/2009 08:39 PM, Mark McLoughlin wrote: On Thu, 2009-10-08 at 22:37 +0200, Michael S. Tsirkin wrote: With commit ee3993069ff55fa6f1c64daf1e09963e340db8e4, posix-aio-compat: avoid signal race when spawning a thread winxp installation on a raw format file fails during disk format, with a