[Qemu-devel] Re: [PATCH] savevm: print migration failure to stderr rather than monitor

2011-01-07 Thread Alex Williamson
On Fri, 2011-01-07 at 16:46 +0100, Jan Kiszka wrote: > Am 07.01.2011 16:39, Alex Williamson wrote: > > On Fri, 2011-01-07 at 09:51 +0100, Jan Kiszka wrote: > >> Am 07.01.2011 08:18, Alex Williamson wrote: > >>> monitor_print only does anything for foreground commands, so we > >>> don't ever see thi

[Qemu-devel] Re: [PATCH] savevm: print migration failure to stderr rather than monitor

2011-01-07 Thread Jan Kiszka
Am 07.01.2011 16:39, Alex Williamson wrote: > On Fri, 2011-01-07 at 09:51 +0100, Jan Kiszka wrote: >> Am 07.01.2011 08:18, Alex Williamson wrote: >>> monitor_print only does anything for foreground commands, so we >>> don't ever see this error message in the case of a 'migrate -d'. >> >> Your chang

[Qemu-devel] Re: [PATCH] savevm: print migration failure to stderr rather than monitor

2011-01-07 Thread Alex Williamson
On Fri, 2011-01-07 at 09:51 +0100, Jan Kiszka wrote: > Am 07.01.2011 08:18, Alex Williamson wrote: > > monitor_print only does anything for foreground commands, so we > > don't ever see this error message in the case of a 'migrate -d'. > > Your change needlessly steals the error from the monitor c

[Qemu-devel] Re: [PATCH] savevm: print migration failure to stderr rather than monitor

2011-01-07 Thread Jan Kiszka
Am 07.01.2011 08:18, Alex Williamson wrote: > monitor_print only does anything for foreground commands, so we > don't ever see this error message in the case of a 'migrate -d'. Your change needlessly steals the error from the monitor console where it belongs if migrate is used without -d. IIRC, mo