[Qemu-devel] Re: [PATCH] scsi-disk: add data direction checking

2010-11-23 Thread Stefan Hajnoczi
On Tue, Nov 23, 2010 at 10:12 AM, Hannes Reinecke wrote: > On 11/23/2010 11:03 AM, Stefan Hajnoczi wrote: >> On Mon, Nov 22, 2010 at 10:15 AM, Hannes Reinecke wrote: >>> @@ -172,6 +170,9 @@ static void scsi_read_data(SCSIRequest *req) >>>     /* No data transfer may already be in progress */ >>>

[Qemu-devel] Re: [PATCH] scsi-disk: add data direction checking

2010-11-23 Thread Hannes Reinecke
On 11/23/2010 11:03 AM, Stefan Hajnoczi wrote: > On Mon, Nov 22, 2010 at 10:15 AM, Hannes Reinecke wrote: >> @@ -172,6 +170,9 @@ static void scsi_read_data(SCSIRequest *req) >> /* No data transfer may already be in progress */ >> assert(r->req.aiocb == NULL); >> >> +if (r->req.cmd.mode

[Qemu-devel] Re: [PATCH] scsi-disk: add data direction checking

2010-11-23 Thread Stefan Hajnoczi
On Mon, Nov 22, 2010 at 10:15 AM, Hannes Reinecke wrote: > @@ -172,6 +170,9 @@ static void scsi_read_data(SCSIRequest *req) >     /* No data transfer may already be in progress */ >     assert(r->req.aiocb == NULL); > > +    if (r->req.cmd.mode == SCSI_XFER_TO_DEV) > +        BADF("Data transfer d