Am 23.12.2010 22:58, schrieb Nicholas A. Bellinger:
On Tue, 2010-12-21 at 12:49 +1100, Benjamin Herrenschmidt wrote:
Yep, so it appears that commit 89c0f6438d16 did introduce the bogus
'double complete' in scsi_read_complete, which I think was intended to
handle residual counts for
On Tue, 2010-12-21 at 12:49 +1100, Benjamin Herrenschmidt wrote:
Yep, so it appears that commit 89c0f6438d16 did introduce the bogus
'double complete' in scsi_read_complete, which I think was intended to
handle residual counts for TYPE_TYPE...
/* Cancel a pending data transfer. */
Yep, so it appears that commit 89c0f6438d16 did introduce the bogus
'double complete' in scsi_read_complete, which I think was intended to
handle residual counts for TYPE_TYPE...
/* Cancel a pending data transfer. */
@@ -251,6 +257,8 @@ static void scsi_read_complete(void * opaque, int
The commit message of this commit says it's a workaround for a problem
with lsi:
- when a read is aborted due to a mark/EOF/EOD/EOM, the len reported to
controller can be 0. LSI controller emulation doesn't know how to manage
this. A workaround found is to call the completion routine
On Wed, 2010-11-24 at 11:46 +0100, Hannes Reinecke wrote:
- when a read is aborted due to a mark/EOF/EOD/EOM, the len
reported to
controller can be 0. LSI controller emulation doesn't know how to
manage
this. A workaround found is to call the completion routine with
SCSI_REASON_DONE just
On 11/25/10 09:46, Benjamin Herrenschmidt wrote:
So far tho, it appears that I can (at least with scsi-disk) rely on
always been eventually called with SCSI_REASON_DONE so my code (and
maybe the usb-msd code too, I haven't verified) relies on that to
complete requests... Is that incorrect ?
On Thu, 2010-11-25 at 09:50 +0100, Gerd Hoffmann wrote:
On 11/25/10 09:46, Benjamin Herrenschmidt wrote:
So far tho, it appears that I can (at least with scsi-disk) rely on
always been eventually called with SCSI_REASON_DONE so my code (and
maybe the usb-msd code too, I haven't verified)
On 11/25/2010 10:01 AM, Benjamin Herrenschmidt wrote:
On Thu, 2010-11-25 at 09:50 +0100, Gerd Hoffmann wrote:
On 11/25/10 09:46, Benjamin Herrenschmidt wrote:
So far tho, it appears that I can (at least with scsi-disk) rely on
always been eventually called with SCSI_REASON_DONE so my code
On Thu, 2010-11-25 at 10:06 +0100, Hannes Reinecke wrote:
No, this is exactly as I'm expecting the SCSI layer to work.
So from the light of this the patch to scsi-generic is valid.
And it really looks like papering over a bug in the lsi HBA code.
Ok. I have no special case tho for a complete()
Right now, I've somewhat come up with:
- client request occurs
- call device send_command()
- if result is 0, assume my complete() was called with
SCSI_REASON_DONE
- else, use sign of result for transfer direction, store the
absolute value as the total expected transfer len
On 11/24/2010 09:18 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a handful of bugfixes for scsi-generic
that where added into:
commit a4194b3f79a85e111f000788ddec05d465748851
Author: Hannes Reinecke h...@suse.de
Date: Mon Nov 22
On Wed, 2010-11-24 at 09:57 +0100, Hannes Reinecke wrote:
On 11/24/2010 09:18 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a handful of bugfixes for scsi-generic
that where added into:
commit a4194b3f79a85e111f000788ddec05d465748851
Am 24.11.2010 09:57, schrieb Hannes Reinecke:
On 11/24/2010 09:18 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a handful of bugfixes for scsi-generic
that where added into:
commit a4194b3f79a85e111f000788ddec05d465748851
Author: Hannes
On 11/24/2010 10:04 AM, Kevin Wolf wrote:
Am 24.11.2010 09:57, schrieb Hannes Reinecke:
On 11/24/2010 09:18 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a handful of bugfixes for scsi-generic
that where added into:
commit
On 11/24/2010 11:34 AM, Kevin Wolf wrote:
Am 24.11.2010 11:16, schrieb Hannes Reinecke:
The second one is actually a genuine error, and a rather old one to
boot. It went in with this commit:
commit 89c0f6438d16ebceccdcd096bbc0b5536146a443
Author: aurel32
Am 24.11.2010 11:16, schrieb Hannes Reinecke:
The second one is actually a genuine error, and a rather old one to
boot. It went in with this commit:
commit 89c0f6438d16ebceccdcd096bbc0b5536146a443
Author: aurel32 aure...@c046a42c-6fe2-441c-8c8c-71466251a162
Date: Fri Oct 17 08:08:56 2008
On Wed, 2010-11-24 at 11:16 +0100, Hannes Reinecke wrote:
On 11/24/2010 10:04 AM, Kevin Wolf wrote:
Am 24.11.2010 09:57, schrieb Hannes Reinecke:
On 11/24/2010 09:18 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds a handful of bugfixes for
17 matches
Mail list logo
