[Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-11 Thread Kevin Wolf
Am 10.05.2010 22:12, schrieb Stefan Weil: The fix is based on a patch from Kevin Wolf. Here his comment: The number of blocks needs to be rounded up to cover all of the virtual hard disk. Without this fix, we can't even open our own images if their size is not a multiple of the block size.

[Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-10 Thread Kevin Wolf
Am 09.05.2010 12:17, schrieb Stefan Weil: Kevin and you are right, and my interpretation of disk_size was wrong. disk_size is not the size used for the blocks (then it would have to be large enough to keep all blocks). disk_size is the number of bytes which are really used for data (so it

[Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-10 Thread François Revol
Le Mon, 10 May 2010 22:12:33 +0200, Stefan Weil a écrit : The fix is based on a patch from Kevin Wolf. Here his comment: The number of blocks needs to be rounded up to cover all of the virtual hard disk. Without this fix, we can't even open our own images if their size is not a multiple of

[Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-09 Thread Stefan Weil
Am 07.05.2010 13:55, schrieb François Revol: Le Fri, 07 May 2010 09:55:23 +0200, Kevin Wolf a écrit : Am 06.05.2010 20:29, schrieb Stefan Weil: This patch fixes a regression introduced by commit 95a2f9bc588c3f83375d87b0a9394f89a1bcfada. The fix is based on a patch from Kevin Wolf. Here his

[Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-07 Thread Kevin Wolf
Am 06.05.2010 20:29, schrieb Stefan Weil: This patch fixes a regression introduced by commit 95a2f9bc588c3f83375d87b0a9394f89a1bcfada. The fix is based on a patch from Kevin Wolf. Here his comment: The number of blocks needs to be rounded up to cover all of the virtual hard disk. Without

[Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-07 Thread François Revol
Le Fri, 07 May 2010 09:55:23 +0200, Kevin Wolf a écrit : Am 06.05.2010 20:29, schrieb Stefan Weil: This patch fixes a regression introduced by commit 95a2f9bc588c3f83375d87b0a9394f89a1bcfada. The fix is based on a patch from Kevin Wolf. Here his comment: The number of blocks needs to