[Qemu-devel] Re: [PATCH 0/4] Improve -icount, fix it with iothread

2011-02-25 Thread Paolo Bonzini
On 02/23/2011 12:39 PM, Jan Kiszka wrote: You should try to trace the event flow in qemu, either via strace, via the built-in tracer (which likely requires a bit more tracepoints), or via a system-level tracer (ftrace / kernelshark). The apparent problem is that 25% of cycles is spent in mutex

[Qemu-devel] Re: [PATCH 0/4] Improve -icount, fix it with iothread

2011-02-23 Thread Edgar E. Iglesias
On Mon, Feb 21, 2011 at 09:51:22AM +0100, Paolo Bonzini wrote: This series redoes the way time spent waiting for I/O is accounted to the vm_clock. The current code is advancing qemu_icount before waiting for I/O. Instead, after the patch qemu_icount is left aside (it is a pure instruction

[Qemu-devel] Re: [PATCH 0/4] Improve -icount, fix it with iothread

2011-02-23 Thread Paolo Bonzini
On 02/23/2011 11:18 AM, Edgar E. Iglesias wrote: Sorry, I don't know the code well enough to give any sensible feedback on patch 2 - 4. I did test them with some of my guests and things seem to be OK with them but quite a bit slower. I saw around 10 - 20% slowdown with a cris guest and -icount

[Qemu-devel] Re: [PATCH 0/4] Improve -icount, fix it with iothread

2011-02-23 Thread Edgar E. Iglesias
On Wed, Feb 23, 2011 at 11:25:54AM +0100, Paolo Bonzini wrote: On 02/23/2011 11:18 AM, Edgar E. Iglesias wrote: Sorry, I don't know the code well enough to give any sensible feedback on patch 2 - 4. I did test them with some of my guests and things seem to be OK with them but quite a bit

[Qemu-devel] Re: [PATCH 0/4] Improve -icount, fix it with iothread

2011-02-23 Thread Jan Kiszka
On 2011-02-23 12:08, Edgar E. Iglesias wrote: On Wed, Feb 23, 2011 at 11:25:54AM +0100, Paolo Bonzini wrote: On 02/23/2011 11:18 AM, Edgar E. Iglesias wrote: Sorry, I don't know the code well enough to give any sensible feedback on patch 2 - 4. I did test them with some of my guests and things

[Qemu-devel] Re: [PATCH 0/4] Improve -icount, fix it with iothread

2011-02-23 Thread Edgar E. Iglesias
On Wed, Feb 23, 2011 at 12:39:52PM +0100, Jan Kiszka wrote: On 2011-02-23 12:08, Edgar E. Iglesias wrote: On Wed, Feb 23, 2011 at 11:25:54AM +0100, Paolo Bonzini wrote: On 02/23/2011 11:18 AM, Edgar E. Iglesias wrote: Sorry, I don't know the code well enough to give any sensible feedback

[Qemu-devel] Re: [PATCH 0/4] Improve -icount, fix it with iothread

2011-02-23 Thread Paolo Bonzini
On 02/23/2011 12:08 PM, Edgar E. Iglesias wrote: No, this supersedes Marcelo's patch. 10-20% doesn't seem comparable to looks like it deadlocked anyway. Also, Jan has ideas on how to remove the synchronization overhead in the main loop for TCG+iothread. I see. I tried booting two of my

[Qemu-devel] Re: [PATCH 0/4] Improve -icount, fix it with iothread

2011-02-23 Thread Jan Kiszka
On 2011-02-23 13:40, Edgar E. Iglesias wrote: On Wed, Feb 23, 2011 at 12:39:52PM +0100, Jan Kiszka wrote: On 2011-02-23 12:08, Edgar E. Iglesias wrote: On Wed, Feb 23, 2011 at 11:25:54AM +0100, Paolo Bonzini wrote: On 02/23/2011 11:18 AM, Edgar E. Iglesias wrote: Sorry, I don't know the code

[Qemu-devel] Re: [PATCH 0/4] Improve -icount, fix it with iothread

2011-02-23 Thread Paolo Bonzini
On 02/23/2011 05:27 PM, Edgar E. Iglesias wrote: For the almost deadlock testcase, I think the CRIS image on the wiki is OK. Ah yes, I was understanding that the watchdog itself slowed down too and didn't trigger. So I was indeed seeing it (and not patient enough to see it boot). Still