[Qemu-devel] Re: [PATCH 01/13] ide: split ide command interpretation off

2010-12-08 Thread Stefan Hajnoczi
On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf ag...@suse.de wrote: The ATA command interpretation code can be used for PATA and SATA interfaces alike. So let's split it out into a separate function. Signed-off-by: Alexander Graf ag...@suse.de --- v6 - v7:  - use bus instead of opaque

[Qemu-devel] Re: [PATCH 01/13] ide: split ide command interpretation off

2010-12-01 Thread Stefan Hajnoczi
On Fri, Nov 26, 2010 at 7:17 PM, Alexander Graf ag...@suse.de wrote: @@ -1853,17 +1850,29 @@ void ide_ioport_write(void *opaque, uint32_t addr, uint32_t val)     default:     case 7:         /* command */ +        ide_exec_cmd(opaque, val); Slightly clearer but only worth changing if you