[Qemu-devel] Re: [PATCH 09/12] savevm: Survive hot-unplug of snapshot device

2010-06-30 Thread Markus Armbruster
Christoph Hellwig h...@lst.de writes: Looks good, Reviewed-by: Christoph Hellwig h...@lst.de Of course specifying an explicit medium for snapshot, be that the snapshot section of a qcow2 image or just a separate flat file and managing that one explicitly would be even better. Indeed.

[Qemu-devel] Re: [PATCH 09/12] savevm: Survive hot-unplug of snapshot device

2010-06-30 Thread Kevin Wolf
Am 25.06.2010 18:53, schrieb Markus Armbruster: savevm.c keeps a pointer to the snapshot block device. If you manage to get that device deleted, the pointer dangles, and the next snapshot operation will crash burn. Unplugging a guest device that uses it does the trick: $

[Qemu-devel] Re: [PATCH 09/12] savevm: Survive hot-unplug of snapshot device

2010-06-30 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 25.06.2010 18:53, schrieb Markus Armbruster: savevm.c keeps a pointer to the snapshot block device. If you manage to get that device deleted, the pointer dangles, and the next snapshot operation will crash burn. Unplugging a guest device that uses it

[Qemu-devel] Re: [PATCH 09/12] savevm: Survive hot-unplug of snapshot device

2010-06-26 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de Of course specifying an explicit medium for snapshot, be that the snapshot section of a qcow2 image or just a separate flat file and managing that one explicitly would be even better.