[Qemu-devel] Re: [PATCH 1/9] Export function for VA defined ram allocation

2009-10-21 Thread Paolo Bonzini
On 10/21/2009 08:06 PM, Anthony Liguori wrote: Alexander Graf wrote: So you would prefer a special #ifdef for s390 in generic code over a specifically for this purpose exported function? Well, you're the boss. I like the special function better, but whatever you say. How is someone supposed

[Qemu-devel] Re: [PATCH 1/9] Export function for VA defined ram allocation

2009-10-21 Thread Anthony Liguori
Paolo Bonzini wrote: What about this: -ram_addr_t qemu_ram_alloc(ram_addr_t size) +ram_addr_t qemu_ram_alloc_at(ram_addr_t size, void *map_at) { RAMBlock *new_block; size = TARGET_PAGE_ALIGN(size); new_block = qemu_malloc(sizeof(*new_block)); -new_block-host =

[Qemu-devel] Re: [PATCH 1/9] Export function for VA defined ram allocation

2009-10-20 Thread Carsten Otte
Alexander Graf wrote: S390 requires vmas for guests to be 256 GB. So we need to directly export mmaps try to use this vma as start address feature to not accidently get over that limit. Hmmh, now that x86 has solved all the problems we should probably move away from using the same page table