[Qemu-devel] Re: [PATCH 2/9] eepro100: Fix endianness issues

2011-04-03 Thread Michael S. Tsirkin
On Fri, Apr 01, 2011 at 07:52:52PM +0200, Stefan Weil wrote: [snip] Thank you for your review, especially for the hints at lduw_phys and potential alignment issues. I'll apply them to a new version of this patch. There was already a function without prefix (stl_le_phys), and the new ones

[Qemu-devel] Re: [PATCH 2/9] eepro100: Fix endianness issues

2011-04-01 Thread Stefan Weil
Am 31.03.2011 23:52, schrieb Michael S. Tsirkin: On Thu, Mar 31, 2011 at 10:33:24PM +0200, Stefan Weil wrote: Like other Intel devices, e100 (eepro100) uses little endian byte order. This patch was tested with these combinations: i386 host, i386 + mipsel guests (le-le) mipsel host, i386 guest

[Qemu-devel] Re: [PATCH 2/9] eepro100: Fix endianness issues

2011-03-31 Thread Michael S. Tsirkin
On Thu, Mar 31, 2011 at 10:33:24PM +0200, Stefan Weil wrote: Like other Intel devices, e100 (eepro100) uses little endian byte order. This patch was tested with these combinations: i386 host, i386 + mipsel guests (le-le) mipsel host, i386 guest (le-le) i386 host, mips + ppc guests (le-be)