[Qemu-devel] Re: [PATCH 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 14:00, Amit Shah wrote: { -return assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +set_read_poll_fd_action(fd, true); +set_read_fd_action(fd, true); +set_write_fd_action(fd,

[Qemu-devel] Re: [PATCH 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually

2011-01-13 Thread Amit Shah
On (Thu) Jan 13 2011 [14:55:25], Gerd Hoffmann wrote: On 01/13/11 14:00, Amit Shah wrote: { -return assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +set_read_poll_fd_action(fd, true); +

[Qemu-devel] Re: [PATCH 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 15:00, Amit Shah wrote: On (Thu) Jan 13 2011 [14:55:25], Gerd Hoffmann wrote: On 01/13/11 14:00, Amit Shah wrote: { -return assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +

[Qemu-devel] Re: [PATCH 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually

2011-01-13 Thread Amit Shah
On (Thu) Jan 13 2011 [15:08:51], Gerd Hoffmann wrote: On 01/13/11 15:00, Amit Shah wrote: On (Thu) Jan 13 2011 [14:55:25], Gerd Hoffmann wrote: On 01/13/11 14:00, Amit Shah wrote: { -return assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +assign_fd_handlers(fd,

[Qemu-devel] Re: [PATCH 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually

2011-01-13 Thread Gerd Hoffmann
Hi, I can't see such a race window given that most qemu code runs serialized anyway. If you call assign_fd_handlers() + set_write_fd_action(false) in sequence I can't see how a select call can happen inbetween ... Not today, but later when we have threads doing this stuff? Unlikely I