[Qemu-devel] Re: [PATCH rfc] pcie: get rid of range checks

2010-10-25 Thread Isaku Yamahata
Some comments below. On Mon, Oct 25, 2010 at 07:05:51AM +0200, Michael S. Tsirkin wrote: > config cycle operations should be idempotent, so > there's no need to complicate code with range checks. > > Signed-off-by: Michael S. Tsirkin > --- > > Untested. Pls comment. > > hw/pcie.c | 96 > ++

[Qemu-devel] Re: [PATCH rfc] pcie: get rid of range checks

2010-10-25 Thread Michael S. Tsirkin
On Mon, Oct 25, 2010 at 03:17:37PM +0900, Isaku Yamahata wrote: > Some comments below. > > On Mon, Oct 25, 2010 at 07:05:51AM +0200, Michael S. Tsirkin wrote: > > config cycle operations should be idempotent, so > > there's no need to complicate code with range checks. > > > > Signed-off-by: Mich