[Qemu-devel] Re: [PATCH v2 2/2] basic machine opts framework

2010-06-03 Thread Anthony Liguori
On 06/01/2010 12:56 PM, Glauber Costa wrote: This patch adds initial support for the -machine option, that allows command line specification of machine attributes (always relying on safe defaults). Besides its value per-se, it is the saner way we found to allow for enabling/disabling of kvm's in-

[Qemu-devel] Re: [PATCH v2 2/2] basic machine opts framework

2010-06-03 Thread Anthony Liguori
On 06/03/2010 01:07 AM, Jan Kiszka wrote: Glauber Costa wrote: On Wed, Jun 02, 2010 at 09:15:10AM +0200, Jan Kiszka wrote: +QemuOptsList qemu_machine_opts = { +.name = "M", +.head = QTAILQ_HEAD_INITIALIZER(qemu_machine_opts.head), +.desc = { +{ +.name

Re: [Qemu-devel] Re: [PATCH v2 2/2] basic machine opts framework

2010-06-03 Thread Paul Brook
> the "irqchip" option, if you note, is not x86-specific, in any case. > Any machine has an irqchip. The first idea was to use something like > "apic=in_kernel|userspace" which would be, that, very x86-centric. How is this not x86-pc specific? All you're doing is creating two different machines,

[Qemu-devel] Re: [PATCH v2 2/2] basic machine opts framework

2010-06-02 Thread Jan Kiszka
Glauber Costa wrote: > On Wed, Jun 02, 2010 at 09:15:10AM +0200, Jan Kiszka wrote: >>> >>> +QemuOptsList qemu_machine_opts = { >>> +.name = "M", >>> +.head = QTAILQ_HEAD_INITIALIZER(qemu_machine_opts.head), >>> +.desc = { >>> +{ >>> +.name = "mach", >>> +

[Qemu-devel] Re: [PATCH v2 2/2] basic machine opts framework

2010-06-02 Thread Glauber Costa
On Wed, Jun 02, 2010 at 09:15:10AM +0200, Jan Kiszka wrote: > > > > +QemuOptsList qemu_machine_opts = { > > +.name = "M", > > +.head = QTAILQ_HEAD_INITIALIZER(qemu_machine_opts.head), > > +.desc = { > > +{ > > +.name = "mach", > > +.type = QEMU_OPT_STRI

[Qemu-devel] Re: [PATCH v2 2/2] basic machine opts framework

2010-06-02 Thread Jan Kiszka
Glauber Costa wrote: > This patch adds initial support for the -machine option, that allows > command line specification of machine attributes (always relying on safe > defaults). Besides its value per-se, it is the saner way we found to > allow for enabling/disabling of kvm's in-kernel irqchip. >