[Qemu-devel] Re: [PATCH v2 3/3] checkpatch: adjust to QEMUisms

2011-01-18 Thread Paolo Bonzini
On 01/17/2011 08:37 PM, Blue Swirl wrote: On Mon, Jan 17, 2011 at 7:40 AM, Paolo Bonzinipbonz...@redhat.com wrote: On 01/15/2011 06:45 PM, Blue Swirl wrote: + if ($level == 0 !$block =~ /^\s*\{/ !$allowed) { I'm not a Perl expert at all, but I think you need

[Qemu-devel] Re: [PATCH v2 3/3] checkpatch: adjust to QEMUisms

2011-01-17 Thread Blue Swirl
On Mon, Jan 17, 2011 at 7:40 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 01/15/2011 06:45 PM, Blue Swirl wrote: +                       if ($level == 0 !$block =~ /^\s*\{/ !$allowed) { I'm not a Perl expert at all, but I think you need parentheses for the argument of !: ! has higher

[Qemu-devel] Re: [PATCH v2 3/3] checkpatch: adjust to QEMUisms

2011-01-16 Thread Paolo Bonzini
On 01/15/2011 06:45 PM, Blue Swirl wrote: + if ($level == 0 !$block =~ /^\s*\{/ !$allowed) { I'm not a Perl expert at all, but I think you need parentheses for the argument of !: if ($level == 0 !($block =~ /^\s*\{/) !$allowed) { Paolo