Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions

2010-12-08 Thread Anthony Liguori
On 12/08/2010 03:15 AM, Stefan Hajnoczi wrote: On Tue, Dec 07, 2010 at 04:02:03PM +0100, Jes Sorensen wrote: On 12/07/10 15:48, Michael Roth wrote: On 12/07/2010 07:31 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: I am not happy with this addition of numbers

Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions

2010-12-08 Thread Jes Sorensen
On 12/08/10 10:23, Stefan Hajnoczi wrote: > From 7.1.3 Reserved identifiers: > > "All identifiers that begin with an underscore and either an uppercase > letter or another underscore are always reserved for any use." > > and > > "All identifiers that begin with an underscore are always reserved

Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions

2010-12-08 Thread Stefan Hajnoczi
On Wed, Dec 08, 2010 at 10:17:50AM +0100, Jes Sorensen wrote: > On 12/08/10 10:15, Stefan Hajnoczi wrote: > > On Tue, Dec 07, 2010 at 04:02:03PM +0100, Jes Sorensen wrote: > >> Anything to avoid qemu_set_fd_handler17() at some point. I think using > >> __qemu_set_fd_handler() encourages people to m

Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions

2010-12-08 Thread Jes Sorensen
On 12/08/10 10:15, Stefan Hajnoczi wrote: > On Tue, Dec 07, 2010 at 04:02:03PM +0100, Jes Sorensen wrote: >> Anything to avoid qemu_set_fd_handler17() at some point. I think using >> __qemu_set_fd_handler() encourages people to modify that code rather >> than copy it. > > I agree that qemu_set_fd_

Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions

2010-12-08 Thread Stefan Hajnoczi
On Tue, Dec 07, 2010 at 04:02:03PM +0100, Jes Sorensen wrote: > On 12/07/10 15:48, Michael Roth wrote: > > On 12/07/2010 07:31 AM, Jes Sorensen wrote: > >> On 12/03/10 19:03, Michael Roth wrote: > >> I am not happy with this addition of numbers to these functions, it > >> doesn't tell us why we hav

Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions

2010-12-07 Thread Jes Sorensen
On 12/07/10 15:48, Michael Roth wrote: > On 12/07/2010 07:31 AM, Jes Sorensen wrote: >> On 12/03/10 19:03, Michael Roth wrote: >>> This allows us to implement an i/o loop outside of vl.c that can >>> interact with objects that use qemu_set_fd_handler() >>> >>> Signed-off-by: Michael Roth >> >> This

Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions

2010-12-07 Thread Michael Roth
On 12/07/2010 07:31 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: This allows us to implement an i/o loop outside of vl.c that can interact with objects that use qemu_set_fd_handler() Signed-off-by: Michael Roth This commit message really tells us nothing. Please be more spec

[Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions

2010-12-07 Thread Jes Sorensen
On 12/03/10 19:03, Michael Roth wrote: > This allows us to implement an i/o loop outside of vl.c that can > interact with objects that use qemu_set_fd_handler() > > Signed-off-by: Michael Roth This commit message really tells us nothing. Please be more specific about what is in the commit. > di