[Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet, v5

2011-01-27 Thread Gerd Hoffmann
Hi, typedef struct qemu_pvmouse_ack { uint32_t features; /* qemu_pvtable_features */ Why does this comment say qemu_pvtable_features and the one above says qemu_pvmouse_features? Not intentional, will fix. Leftover because it is misspelled (t in table*t* missing), so the

[Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet, v5

2011-01-27 Thread Alon Levy
On Thu, Jan 27, 2011 at 02:11:35PM +0100, Gerd Hoffmann wrote: Hi, Next revision the pvmouse protocol. It is quite different now, I've decided to move to a model with one message per updated value, simliar to the linux input layer. There isn't a mouse move message any more. A mouse

[Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet, v5

2011-01-27 Thread Alon Levy
On Thu, Jan 27, 2011 at 04:32:40PM +0100, Gerd Hoffmann wrote: Hi, typedef struct qemu_pvmouse_ack { uint32_t features; /* qemu_pvtable_features */ Why does this comment say qemu_pvtable_features and the one above says qemu_pvmouse_features? Not intentional, will fix. Leftover

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-14 Thread Gerd Hoffmann
Hi, I think that has to be outside of the device. There are so many ways to map mice to multi heads. In fact, one mouse could easily map to a single device. It's almost something that really should be part of the guest configuration. Ok, reasonable. Multihead with spice pretty much

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-14 Thread Daniel P. Berrange
On Fri, Jan 14, 2011 at 09:49:40AM +0100, Gerd Hoffmann wrote: That maybe implies that we need an offscreen coordinate for the mouse so that you can hide the mouse when it leaves one window. Hmm? I fail to see why multihead is special here. If you show two mice in the guest, would X render

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-14 Thread Anthony Liguori
On 01/14/2011 04:48 AM, Daniel P. Berrange wrote: NB having all mice bound to one cursor is merely the historical default behaviour. IIUC the recent Multi-Pointer X feature lets you now have multiple cursors, one per pointing device.

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-14 Thread Alon Levy
On Fri, Jan 14, 2011 at 10:48:50AM +, Daniel P. Berrange wrote: On Fri, Jan 14, 2011 at 09:49:40AM +0100, Gerd Hoffmann wrote: That maybe implies that we need an offscreen coordinate for the mouse so that you can hide the mouse when it leaves one window. Hmm? I fail to see why

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-14 Thread Daniel P. Berrange
On Fri, Jan 14, 2011 at 04:28:52PM +0200, Alon Levy wrote: On Fri, Jan 14, 2011 at 10:48:50AM +, Daniel P. Berrange wrote: On Fri, Jan 14, 2011 at 09:49:40AM +0100, Gerd Hoffmann wrote: That maybe implies that we need an offscreen coordinate for the mouse so that you can hide the

[Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-13 Thread Stefan Hajnoczi
Can you elaborate how the spice display channel comes into play? On a physical machine you just have input devices with no notion of display. It's up to the windowing system to process input events and handle multihead. Why does a pv tablet tie itself to a display channel? What about mouse

[Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 12:01, Stefan Hajnoczi wrote: Can you elaborate how the spice display channel comes into play? On a physical machine you just have input devices with no notion of display. It's up to the windowing system to process input events and handle multihead. Why does a pv tablet tie

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
On 01/13/2011 05:51 AM, Gerd Hoffmann wrote: On 01/13/11 12:01, Stefan Hajnoczi wrote: Can you elaborate how the spice display channel comes into play? On a physical machine you just have input devices with no notion of display. It's up to the windowing system to process input events and

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 16:55, Anthony Liguori wrote: On 01/13/2011 05:51 AM, Gerd Hoffmann wrote: On 01/13/11 12:01, Stefan Hajnoczi wrote: Can you elaborate how the spice display channel comes into play? On a physical machine you just have input devices with no notion of display. It's up to the

[Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-13 Thread Alon Levy
On Thu, Jan 13, 2011 at 11:19:52AM +0100, Gerd Hoffmann wrote: Hi, Just throwing a quick writeup into the ring to kickstart the design discussion ;) I apologize for not reading everything before sending, I just don't want to forget this detail: Whatever we design needs to address having

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
On 01/13/2011 11:08 AM, Gerd Hoffmann wrote: On 01/13/11 16:55, Anthony Liguori wrote: On 01/13/2011 05:51 AM, Gerd Hoffmann wrote: On 01/13/11 12:01, Stefan Hajnoczi wrote: Can you elaborate how the spice display channel comes into play? On a physical machine you just have input devices