Re: [Qemu-devel] Throttling groups vs filter nodes

2017-05-30 Thread Kevin Wolf
Am 30.05.2017 um 16:29 hat Alberto Garcia geschrieben: > On Sat 27 May 2017 09:56:03 AM CEST, Stefan Hajnoczi wrote: > > Throttling groups allow multiple drives to share the same throttling > > state (i.e. budget) between them. Manos is working on moving the > > throttling code into a block

Re: [Qemu-devel] Throttling groups vs filter nodes

2017-05-30 Thread Alberto Garcia
On Sat 27 May 2017 09:56:03 AM CEST, Stefan Hajnoczi wrote: > Throttling groups allow multiple drives to share the same throttling > state (i.e. budget) between them. Manos is working on moving the > throttling code into a block filter driver so it is no longer > hardcoded into the I/O code path.

Re: [Qemu-devel] Throttling groups vs filter nodes

2017-05-30 Thread Alberto Garcia
On Mon 29 May 2017 10:57:37 PM CEST, Manos Pitsidianakis wrote: >>> A quirk in the current implementation is that the throttling limits >>> for the group are overwritten by each -drive throttling.group=group0. >>> Limits for all but the last -drive in a group are ignored. >> - bps or iops != 0

Re: [Qemu-devel] Throttling groups vs filter nodes

2017-05-30 Thread Kevin Wolf
[ Cc: qemu-block - noticed only now that it's missing ] Am 29.05.2017 um 22:57 hat Manos Pitsidianakis geschrieben: > On Mon, May 29, 2017 at 05:05:17PM +0200, Alberto Garcia wrote: > >On Sat 27 May 2017 09:56:03 AM CEST, Stefan Hajnoczi wrote: > >>A quirk in the current implementation is that

Re: [Qemu-devel] Throttling groups vs filter nodes

2017-05-30 Thread Stefan Hajnoczi
On Mon, May 29, 2017 at 05:50:36PM +0200, Kevin Wolf wrote: > After writing this, my gut feeling is that -object might well be worth > it. Yes, a real -object would be cleanest. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] Throttling groups vs filter nodes

2017-05-29 Thread Manos Pitsidianakis
On Mon, May 29, 2017 at 05:05:17PM +0200, Alberto Garcia wrote: On Sat 27 May 2017 09:56:03 AM CEST, Stefan Hajnoczi wrote: A quirk in the current implementation is that the throttling limits for the group are overwritten by each -drive throttling.group=group0. Limits for all but the last

Re: [Qemu-devel] Throttling groups vs filter nodes

2017-05-29 Thread Kevin Wolf
Am 27.05.2017 um 09:56 hat Stefan Hajnoczi geschrieben: > Throttling groups allow multiple drives to share the same throttling > state (i.e. budget) between them. Manos is working on moving the > throttling code into a block filter driver so it is no longer > hardcoded into the I/O code path. >

Re: [Qemu-devel] Throttling groups vs filter nodes

2017-05-29 Thread Alberto Garcia
On Sat 27 May 2017 09:56:03 AM CEST, Stefan Hajnoczi wrote: > A quirk in the current implementation is that the throttling limits > for the group are overwritten by each -drive throttling.group=group0. > Limits for all but the last -drive in a group are ignored. > > There is no way to associate

[Qemu-devel] Throttling groups vs filter nodes

2017-05-27 Thread Stefan Hajnoczi
Throttling groups allow multiple drives to share the same throttling state (i.e. budget) between them. Manos is working on moving the throttling code into a block filter driver so it is no longer hardcoded into the I/O code path. Throttling groups are not defined explicitly using -object syntax.