Re: [Qemu-devel] a suggestion to extend the query block stats commands for multi-disk case

2016-12-06 Thread Dou Liyang
Hi Paolo,Stefan, At 12/05/2016 07:57 PM, Paolo Bonzini wrote: On 05/12/2016 12:53, Stefan Hajnoczi wrote: Adding the BlockBackend *query_blk parameter is a reasonable short-term workaround. I wonder if the polling stats APIs need to be rethought in the longer term. Regarding the low-level d

Re: [Qemu-devel] a suggestion to extend the query block stats commands for multi-disk case

2016-12-05 Thread Dou Liyang
Hi stefan, At 12/05/2016 07:53 PM, Stefan Hajnoczi wrote: On Mon, Dec 05, 2016 at 04:56:38PM +0800, Dou Liyang wrote: Hi all, Currently, in Qemu, we query the block states by using “info blockstats”. For each disk, the command calls “bdrv_query_stats” function to get the info of block states i

Re: [Qemu-devel] a suggestion to extend the query block stats commands for multi-disk case

2016-12-05 Thread Paolo Bonzini
On 05/12/2016 12:53, Stefan Hajnoczi wrote: > Adding the BlockBackend *query_blk parameter is a reasonable short-term > workaround. I wonder if the polling stats APIs need to be rethought in > the longer term. > > Regarding the low-level details of block statistics inside QEMU, we can > probabl

Re: [Qemu-devel] a suggestion to extend the query block stats commands for multi-disk case

2016-12-05 Thread Stefan Hajnoczi
On Mon, Dec 05, 2016 at 04:56:38PM +0800, Dou Liyang wrote: > Hi all, > > Currently, in Qemu, we query the block states by using “info blockstats”. > For each disk, the command calls “bdrv_query_stats” function to get the > info of block states in “qmp_query_blockstats” . > Since commit 13344f3a,

[Qemu-devel] a suggestion to extend the query block stats commands for multi-disk case

2016-12-05 Thread Dou Liyang
Hi all, Currently, in Qemu, we query the block states by using “info blockstats”. For each disk, the command calls “bdrv_query_stats” function to get the info of block states in “qmp_query_blockstats” . Since commit 13344f3a, Stefan added mutex to ensures that the dataplane IOThread and the main