Re: [Qemu-devel] active block commit bug?

2014-06-05 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 06/04/2014 08:09 PM, Fam Zheng wrote: Sounds like we have an off-by-one condition if empty files behave differently from other files. We ought to fix that bug (not that your normal guest will ever have a 0-length backing file, but this was what I was

Re: [Qemu-devel] active block commit bug?

2014-06-05 Thread Kevin Wolf
Am 05.06.2014 um 09:06 hat Markus Armbruster geschrieben: Eric Blake ebl...@redhat.com writes: On 06/04/2014 08:09 PM, Fam Zheng wrote: Sounds like we have an off-by-one condition if empty files behave differently from other files. We ought to fix that bug (not that your normal guest

Re: [Qemu-devel] active block commit bug?

2014-06-05 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 05.06.2014 um 09:06 hat Markus Armbruster geschrieben: Eric Blake ebl...@redhat.com writes: On 06/04/2014 08:09 PM, Fam Zheng wrote: Sounds like we have an off-by-one condition if empty files behave differently from other files. We ought to fix

Re: [Qemu-devel] active block commit bug?

2014-06-05 Thread Amos Kong
On Thu, Jun 05, 2014 at 09:06:42AM +0200, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: On 06/04/2014 08:09 PM, Fam Zheng wrote: Sounds like we have an off-by-one condition if empty files behave differently from other files. We ought to fix that bug (not that your

[Qemu-devel] active block commit bug?

2014-06-04 Thread Eric Blake
Testing on Fedora 20 (JSON output slightly modified for legibility): $ qemu-kvm --version QEMU emulator version 2.0.0, Copyright (c) 2003-2008 Fabrice Bellard $ touch f $ qemu-kvm -qmp stdio -drive file=f = {QMP: {version: {qemu: {micro: 0, minor: 0, major: 2}, package: }, capabilities: []}}

Re: [Qemu-devel] active block commit bug?

2014-06-04 Thread Jeff Cody
On Wed, Jun 04, 2014 at 04:55:04PM -0600, Eric Blake wrote: Testing on Fedora 20 (JSON output slightly modified for legibility): $ qemu-kvm --version QEMU emulator version 2.0.0, Copyright (c) 2003-2008 Fabrice Bellard $ touch f $ qemu-kvm -qmp stdio -drive file=f = {QMP: {version: {qemu:

Re: [Qemu-devel] active block commit bug?

2014-06-04 Thread Eric Blake
On 06/04/2014 06:12 PM, Jeff Cody wrote: Huh? I thought that an active commit was not supposed to complete automatically, but that the job would remain around until I either 'block-job-cancel' or 'block-job-complete' it. That is, I should have gotten a BLOCK_JOB_READY event and still see the

Re: [Qemu-devel] active block commit bug?

2014-06-04 Thread Fam Zheng
On Wed, 06/04 19:54, Eric Blake wrote: On 06/04/2014 06:12 PM, Jeff Cody wrote: Huh? I thought that an active commit was not supposed to complete automatically, but that the job would remain around until I either 'block-job-cancel' or 'block-job-complete' it. That is, I should have

Re: [Qemu-devel] active block commit bug?

2014-06-04 Thread Eric Blake
On 06/04/2014 08:09 PM, Fam Zheng wrote: Sounds like we have an off-by-one condition if empty files behave differently from other files. We ought to fix that bug (not that your normal guest will ever have a 0-length backing file, but this was what I was trying to use for libvirt's probing of

Re: [Qemu-devel] active block commit bug?

2014-06-04 Thread Fam Zheng
On Wed, 06/04 20:55, Eric Blake wrote: On 06/04/2014 08:09 PM, Fam Zheng wrote: Sounds like we have an off-by-one condition if empty files behave differently from other files. We ought to fix that bug (not that your normal guest will ever have a 0-length backing file, but this was what I