Re: [Qemu-devel] chardev's and fd's in monitors

Paolo Bonzini writes: > On 21/10/2016 11:12, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 20/10/2016 10:37, Daniel P. Berrange wrote: You have a problem of context - if you have multiple monitors, how do you know which to send the error back to if you're not in the even

Re: [Qemu-devel] chardev's and fd's in monitors

On 21/10/2016 11:12, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 20/10/2016 10:37, Daniel P. Berrange wrote: >>> You have a problem of context - if you have multiple monitors, how do >>> you know which to send the error back to if you're not in the event >>> loop thread, and thus c

Re: [Qemu-devel] chardev's and fd's in monitors

* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, Oct 21, 2016 at 11:06:21AM +0200, Markus Armbruster wrote: > > "Dr. David Alan Gilbert" writes: > > > > > * Markus Armbruster (arm...@redhat.com) wrote: > > >> "Daniel P. Berrange" writes: > > [...] > > >> > Realistically all the major

Re: [Qemu-devel] chardev's and fd's in monitors

* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Daniel P. Berrange" writes: > [...] > >> > Realistically all the major backend subsystems (chardev, network, block, > >> > ui and migration) need to be con

Re: [Qemu-devel] chardev's and fd's in monitors

On Fri, Oct 21, 2016 at 11:06:21AM +0200, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Daniel P. Berrange" writes: > [...] > >> > Realistically all the major backend subsystems (chardev, network, block, > >> > ui and migra

Re: [Qemu-devel] chardev's and fd's in monitors

On Thu, Oct 20, 2016 at 06:56:11PM +0200, Paolo Bonzini wrote: > > > On 20/10/2016 10:37, Daniel P. Berrange wrote: > > You have a problem of context - if you have multiple monitors, how do > > you know which to send the error back to if you're not in the event > > loop thread, and thus cur_mon i

Re: [Qemu-devel] chardev's and fd's in monitors

Paolo Bonzini writes: > On 20/10/2016 10:37, Daniel P. Berrange wrote: >> You have a problem of context - if you have multiple monitors, how do >> you know which to send the error back to if you're not in the event >> loop thread, and thus cur_mon is NULL. With Marc-Andre's series which >> allows

Re: [Qemu-devel] chardev's and fd's in monitors

"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Daniel P. Berrange" writes: [...] >> > Realistically all the major backend subsystems (chardev, network, block, >> > ui and migration) need to be converted to Error ** propagation, since >> > they all ultimatel

Re: [Qemu-devel] chardev's and fd's in monitors

* Markus Armbruster (arm...@redhat.com) wrote: > "Daniel P. Berrange" writes: > > > On Thu, Oct 20, 2016 at 12:42:01PM +0200, Markus Armbruster wrote: > >> "Dr. David Alan Gilbert" writes: > >> > >> > * Daniel P. Berrange (berra...@redhat.com) wrote: > >> >> On Thu, Oct 20, 2016 at 10:55:52AM +

Re: [Qemu-devel] chardev's and fd's in monitors

* Daniel P. Berrange (berra...@redhat.com) wrote: > On Wed, Oct 19, 2016 at 07:06:16PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Wed, Oct 19, 2016 at 02:16:05PM +0200, Markus Armbruster wrote: > > > > "Daniel P. Berrange" writes: > > > > >

Re: [Qemu-devel] chardev's and fd's in monitors

On 20/10/2016 10:37, Daniel P. Berrange wrote: > You have a problem of context - if you have multiple monitors, how do > you know which to send the error back to if you're not in the event > loop thread, and thus cur_mon is NULL. With Marc-Andre's series which > allows proper async command proces

Re: [Qemu-devel] chardev's and fd's in monitors

"Daniel P. Berrange" writes: > On Thu, Oct 20, 2016 at 12:42:01PM +0200, Markus Armbruster wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Daniel P. Berrange (berra...@redhat.com) wrote: >> >> On Thu, Oct 20, 2016 at 10:55:52AM +0200, Markus Armbruster wrote: >> >> >> >> Our code has incr

Re: [Qemu-devel] chardev's and fd's in monitors

"Daniel P. Berrange" writes: > On Thu, Oct 20, 2016 at 12:01:08PM +0100, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >> > "Dr. David Alan Gilbert" writes: >> >> > > The problem is that our way of propagating errors actively discourages >> > > people from add

Re: [Qemu-devel] chardev's and fd's in monitors

On Thu, Oct 20, 2016 at 12:01:08PM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Dr. David Alan Gilbert" writes: > > > > The problem is that our way of propagating errors actively discourages > > > people from adding errors and you're left with lots o

Re: [Qemu-devel] chardev's and fd's in monitors

On Thu, Oct 20, 2016 at 12:42:01PM +0200, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > >> On Thu, Oct 20, 2016 at 10:55:52AM +0200, Markus Armbruster wrote: > >> > >> Our code has increasingly converted to propagate errors

Re: [Qemu-devel] chardev's and fd's in monitors

* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > The problem is that our way of propagating errors actively discourages > > people from adding errors and you're left with lots of useless invented > > errno's. > > error_report makes it easy for people to scat

Re: [Qemu-devel] chardev's and fd's in monitors

Marc-André Lureau writes: > Hi > > On Thu, Oct 20, 2016 at 11:38 AM Daniel P. Berrange > wrote: > >> On Wed, Oct 19, 2016 at 07:06:16PM +0100, Dr. David Alan Gilbert wrote: >> > * Daniel P. Berrange (berra...@redhat.com) wrote: [...] >> > > If we make cur_mon a thread-local, then error_report()

Re: [Qemu-devel] chardev's and fd's in monitors

"Dr. David Alan Gilbert" writes: > * Daniel P. Berrange (berra...@redhat.com) wrote: >> On Thu, Oct 20, 2016 at 10:55:52AM +0200, Markus Armbruster wrote: >> > "Dr. David Alan Gilbert" writes: >> > >> > > * Daniel P. Berrange (berra...@redhat.com) wrote: >> > >> On Wed, Oct 19, 2016 at 02:16:05

Re: [Qemu-devel] chardev's and fd's in monitors

* Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Oct 20, 2016 at 10:55:52AM +0200, Markus Armbruster wrote: > > "Dr. David Alan Gilbert" writes: > > > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > >> On Wed, Oct 19, 2016 at 02:16:05PM +0200, Markus Armbruster wrote: > > >>

Re: [Qemu-devel] chardev's and fd's in monitors

On Thu, Oct 20, 2016 at 10:55:52AM +0200, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > >> On Wed, Oct 19, 2016 at 02:16:05PM +0200, Markus Armbruster wrote: > >> > "Daniel P. Berrange" writes: > >> > > >> > > On Wed, Oct 1

Re: [Qemu-devel] chardev's and fd's in monitors

"Dr. David Alan Gilbert" writes: > * Daniel P. Berrange (berra...@redhat.com) wrote: >> On Wed, Oct 19, 2016 at 02:16:05PM +0200, Markus Armbruster wrote: >> > "Daniel P. Berrange" writes: >> > >> > > On Wed, Oct 19, 2016 at 11:05:53AM +0100, Dr. David Alan Gilbert wrote: >> > >> >> > >> We ne

Re: [Qemu-devel] chardev's and fd's in monitors

Hi On Thu, Oct 20, 2016 at 11:38 AM Daniel P. Berrange wrote: > On Wed, Oct 19, 2016 at 07:06:16PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Wed, Oct 19, 2016 at 02:16:05PM +0200, Markus Armbruster wrote: > > > > "Daniel P. Berrange" wri

Re: [Qemu-devel] chardev's and fd's in monitors

On Wed, Oct 19, 2016 at 07:06:16PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Wed, Oct 19, 2016 at 02:16:05PM +0200, Markus Armbruster wrote: > > > "Daniel P. Berrange" writes: > > > > > > > On Wed, Oct 19, 2016 at 11:05:53AM +0100, Dr. David A

Re: [Qemu-devel] chardev's and fd's in monitors

On Wed, Oct 19, 2016 at 10:51:07PM +0200, Paolo Bonzini wrote: > > > On 19/10/2016 19:01, Dr. David Alan Gilbert wrote: > > * Paolo Bonzini (pbonz...@redhat.com) wrote: > >> > >> > >> On 18/10/2016 16:01, Daniel P. Berrange wrote: > > > > I already use error_report's in places in migratio

Re: [Qemu-devel] chardev's and fd's in monitors

On 19/10/2016 19:01, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> >> >> On 18/10/2016 16:01, Daniel P. Berrange wrote: > > I already use error_report's in places in migration threads of various > types; I'm not sure if that's a problem. >>> Unless th

Re: [Qemu-devel] chardev's and fd's in monitors

* Daniel P. Berrange (berra...@redhat.com) wrote: > On Wed, Oct 19, 2016 at 02:16:05PM +0200, Markus Armbruster wrote: > > "Daniel P. Berrange" writes: > > > > > On Wed, Oct 19, 2016 at 11:05:53AM +0100, Dr. David Alan Gilbert wrote: > > >> > > >> We need a way to be able to report an error with

Re: [Qemu-devel] chardev's and fd's in monitors

* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 18/10/2016 16:01, Daniel P. Berrange wrote: > >> > > >> > I already use error_report's in places in migration threads of various > >> > types; I'm not sure if that's a problem. > > Unless those places are protected by the big qemu lock, that

Re: [Qemu-devel] chardev's and fd's in monitors

On 18/10/2016 16:01, Daniel P. Berrange wrote: >> > >> > I already use error_report's in places in migration threads of various >> > types; I'm not sure if that's a problem. > Unless those places are protected by the big qemu lock, that sounds > not good. error_report calls into error_vprintf wh

Re: [Qemu-devel] chardev's and fd's in monitors

On Wed, Oct 19, 2016 at 02:16:05PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Wed, Oct 19, 2016 at 11:05:53AM +0100, Dr. David Alan Gilbert wrote: > >> > >> We need a way to be able to report an error without plumbing error_setg > >> up the stack; if you're saying er

Re: [Qemu-devel] chardev's and fd's in monitors

"Daniel P. Berrange" writes: > On Wed, Oct 19, 2016 at 11:05:53AM +0100, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >> > "Daniel P. Berrange" writes: >> > >> > > On Wed, Oct 19, 2016 at 09:12:11AM +0100, Dr. David Alan Gilbert wrote: >> > >> * Markus Armbrus

Re: [Qemu-devel] chardev's and fd's in monitors

On Wed, Oct 19, 2016 at 11:05:53AM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Daniel P. Berrange" writes: > > > > > On Wed, Oct 19, 2016 at 09:12:11AM +0100, Dr. David Alan Gilbert wrote: > > >> * Markus Armbruster (arm...@redhat.com) wrote: > > >>

Re: [Qemu-devel] chardev's and fd's in monitors

* Markus Armbruster (arm...@redhat.com) wrote: > "Daniel P. Berrange" writes: > > > On Wed, Oct 19, 2016 at 09:12:11AM +0100, Dr. David Alan Gilbert wrote: > >> * Markus Armbruster (arm...@redhat.com) wrote: > >> > "Daniel P. Berrange" writes: > >> > > >> > > On Tue, Oct 18, 2016 at 02:52:13PM

Re: [Qemu-devel] chardev's and fd's in monitors

"Daniel P. Berrange" writes: > On Wed, Oct 19, 2016 at 09:12:11AM +0100, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >> > "Daniel P. Berrange" writes: >> > >> > > On Tue, Oct 18, 2016 at 02:52:13PM +0100, Dr. David Alan Gilbert wrote: [...] >> > >> I already

Re: [Qemu-devel] chardev's and fd's in monitors

On Wed, Oct 19, 2016 at 09:12:11AM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Daniel P. Berrange" writes: > > > > > On Tue, Oct 18, 2016 at 02:52:13PM +0100, Dr. David Alan Gilbert wrote: > > >> * Daniel P. Berrange (berra...@redhat.com) wrote: > >

Re: [Qemu-devel] chardev's and fd's in monitors

* Markus Armbruster (arm...@redhat.com) wrote: > "Daniel P. Berrange" writes: > > > On Tue, Oct 18, 2016 at 02:52:13PM +0100, Dr. David Alan Gilbert wrote: > >> * Daniel P. Berrange (berra...@redhat.com) wrote: > >> > On Tue, Oct 18, 2016 at 02:25:25PM +0100, Dr. David Alan Gilbert wrote: > >> >

Re: [Qemu-devel] chardev's and fd's in monitors

"Daniel P. Berrange" writes: > On Tue, Oct 18, 2016 at 02:52:13PM +0100, Dr. David Alan Gilbert wrote: >> * Daniel P. Berrange (berra...@redhat.com) wrote: >> > On Tue, Oct 18, 2016 at 02:25:25PM +0100, Dr. David Alan Gilbert wrote: >> > > * Daniel P. Berrange (berra...@redhat.com) wrote: >> > >

Re: [Qemu-devel] chardev's and fd's in monitors

On Tue, Oct 18, 2016 at 07:53:51PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Tue, Oct 18, 2016 at 02:52:13PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > On Tue, Oct 18, 2016 at 02:25:25PM

Re: [Qemu-devel] chardev's and fd's in monitors

* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, Oct 18, 2016 at 02:52:13PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Tue, Oct 18, 2016 at 02:25:25PM +0100, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrange (berra...@redh

Re: [Qemu-devel] chardev's and fd's in monitors

On Tue, Oct 18, 2016 at 02:52:13PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Tue, Oct 18, 2016 at 02:25:25PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > On Tue, Oct 18, 2016 at 12:32:02PM

Re: [Qemu-devel] chardev's and fd's in monitors

* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, Oct 18, 2016 at 02:25:25PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Tue, Oct 18, 2016 at 12:32:02PM +0100, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrange (berra...@redh

Re: [Qemu-devel] chardev's and fd's in monitors

On Tue, Oct 18, 2016 at 02:25:25PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Tue, Oct 18, 2016 at 12:32:02PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > On Wed, Oct 12, 2016 at 08:15:02PM

Re: [Qemu-devel] chardev's and fd's in monitors

* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, Oct 18, 2016 at 12:32:02PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > > > > Hi, > > > > I had a look at a cou

Re: [Qemu-devel] chardev's and fd's in monitors

* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, Oct 18, 2016 at 02:08:14PM +0200, Markus Armbruster wrote: > > "Daniel P. Berrange" writes: > > > > > On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > > >> Hi, > > >> I had a look at a couple of readline like l

Re: [Qemu-devel] chardev's and fd's in monitors

On Tue, Oct 18, 2016 at 02:08:14PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > >> Hi, > >> I had a look at a couple of readline like libraries; > >> editline and linenoise. A difficulty with usin

Re: [Qemu-devel] chardev's and fd's in monitors

"Daniel P. Berrange" writes: > On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: >> Hi, >> I had a look at a couple of readline like libraries; >> editline and linenoise. A difficulty with using them is that >> they both want fd's or FILE*'s; editline takes either but >>

Re: [Qemu-devel] chardev's and fd's in monitors

On Tue, Oct 18, 2016 at 12:32:02PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > > > Hi, > > > I had a look at a couple of readline like libraries; > > > editline and linenoise

Re: [Qemu-devel] chardev's and fd's in monitors

Hi On Tue, Oct 18, 2016 at 2:41 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Tue, Oct 18, 2016 at 2:32 PM Dr. David Alan Gilbert < > dgilb...@redhat.com> wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David A

Re: [Qemu-devel] chardev's and fd's in monitors

Hi On Tue, Oct 18, 2016 at 2:32 PM Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > > > Hi, > > > I had a look at a couple of readline like libraries; > > > editline and linenoise. A

Re: [Qemu-devel] chardev's and fd's in monitors

* Daniel P. Berrange (berra...@redhat.com) wrote: > On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > > Hi, > > I had a look at a couple of readline like libraries; > > editline and linenoise. A difficulty with using them is that > > they both want fd's or FILE*'s; editli

Re: [Qemu-devel] chardev's and fd's in monitors

On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > Hi, > I had a look at a couple of readline like libraries; > editline and linenoise. A difficulty with using them is that > they both want fd's or FILE*'s; editline takes either but > from a brief look I think it's expecti

Re: [Qemu-devel] chardev's and fd's in monitors

On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > Hi, > I had a look at a couple of readline like libraries; > editline and linenoise. A difficulty with using them is that > they both want fd's or FILE*'s; editline takes either but > from a brief look I think it's expecti

Re: [Qemu-devel] chardev's and fd's in monitors

* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Wed, Oct 12, 2016 at 11:15 PM Dr. David Alan Gilbert > wrote: > > > Hi, > > I had a look at a couple of readline like libraries; > > editline and linenoise. A difficulty with using them is that > > they both want fd's or FILE

Re: [Qemu-devel] chardev's and fd's in monitors

Hi On Wed, Oct 12, 2016 at 11:15 PM Dr. David Alan Gilbert wrote: > Hi, > I had a look at a couple of readline like libraries; > editline and linenoise. A difficulty with using them is that > they both want fd's or FILE*'s; editline takes either but > from a brief look I think it's expecting

[Qemu-devel] chardev's and fd's in monitors

Hi, I had a look at a couple of readline like libraries; editline and linenoise. A difficulty with using them is that they both want fd's or FILE*'s; editline takes either but from a brief look I think it's expecting to extract the fd. That makes them tricky to integrate into qemu, where the cha