Re: [Qemu-devel] git master build failure in 9pfs

On Fri, 3 Mar 2017 12:28:01 -0600 Eric Blake wrote: > On 03/03/2017 12:15 PM, Greg Kurz wrote: > > > > > O_PATH | O_NOFOLLOW is a special case as described in the last paragraph > > of O_PATH in the man page: > > > > If pathname is a symbolic link and the

Re: [Qemu-devel] git master build failure in 9pfs

On 03/03/2017 12:15 PM, Greg Kurz wrote: > > O_PATH | O_NOFOLLOW is a special case as described in the last paragraph > of O_PATH in the man page: > > If pathname is a symbolic link and the O_NOFOLLOW flag is also > specified, then the call returns a file

Re: [Qemu-devel] git master build failure in 9pfs

On Fri, 3 Mar 2017 12:11:36 -0600 Eric Blake wrote: > On 03/03/2017 10:43 AM, Greg Kurz wrote: > > >>> +#ifndef O_PATH > >>> +#define O_PATH 0 > >>> +#endif > >> > >> Isn't the use of O_PATH required in order to fix the recent > >> security vulnerability in 9p ? If

Re: [Qemu-devel] git master build failure in 9pfs

On 03/03/2017 10:43 AM, Greg Kurz wrote: >>> +#ifndef O_PATH >>> +#define O_PATH 0 >>> +#endif >> >> Isn't the use of O_PATH required in order to fix the recent >> security vulnerability in 9p ? If so, then defining it to >> 0 means the QEMU is silently becoming vulnerable once again >>

Re: [Qemu-devel] git master build failure in 9pfs

On 03/03/2017 10:40 AM, Eric Blake wrote: >> Isn't the use of O_PATH required in order to fix the recent >> security vulnerability in 9p ? If so, then defining it to >> 0 means the QEMU is silently becoming vulnerable once again >> which I don't think is a good idea. > > My understanding is

Re: [Qemu-devel] git master build failure in 9pfs

On Fri, 3 Mar 2017 16:21:28 + "Daniel P. Berrange" wrote: > On Fri, Mar 03, 2017 at 10:55:01AM -0500, G 3 wrote: > > > > On Mar 3, 2017, at 10:44 AM, Greg Kurz wrote: > > > > > On Fri, 3 Mar 2017 10:28:00 -0500 > > > G 3 wrote: > > > >

Re: [Qemu-devel] git master build failure in 9pfs

On Fri, Mar 03, 2017 at 10:40:13AM -0600, Eric Blake wrote: > On 03/03/2017 10:21 AM, Daniel P. Berrange wrote: > > >> > >> +#ifndef O_PATH > >> +#define O_PATH 0 > >> +#endif > > > > Isn't the use of O_PATH required in order to fix the recent > > security vulnerability in 9p ? If so, then

Re: [Qemu-devel] git master build failure in 9pfs

On 03/03/2017 10:21 AM, Daniel P. Berrange wrote: I remember years ago something like O_PATH was not defined on Mac OS X, so the solution was to define the constant as zero. Something like this: #ifndef O_PATH #define O_PATH 0 #endif Maybe this

Re: [Qemu-devel] git master build failure in 9pfs

On Mar 3, 2017, at 11:21 AM, Daniel P. Berrange wrote: On Fri, Mar 03, 2017 at 10:55:01AM -0500, G 3 wrote: On Mar 3, 2017, at 10:44 AM, Greg Kurz wrote: On Fri, 3 Mar 2017 10:28:00 -0500 G 3 wrote: On Mar 3, 2017, at 9:59 AM, qemu-devel-requ...@nongnu.org

Re: [Qemu-devel] git master build failure in 9pfs

On Fri, Mar 03, 2017 at 10:55:01AM -0500, G 3 wrote: > > On Mar 3, 2017, at 10:44 AM, Greg Kurz wrote: > > > On Fri, 3 Mar 2017 10:28:00 -0500 > > G 3 wrote: > > > > > On Mar 3, 2017, at 9:59 AM, qemu-devel-requ...@nongnu.org wrote: > > > > On 02/03/17 17:40, Daniel

Re: [Qemu-devel] git master build failure in 9pfs

On Fri, 3 Mar 2017 15:58:13 + Peter Maydell wrote: > On 3 March 2017 at 15:55, G 3 wrote: > > Here is the patch. I think we should let Mark or some else test it to see if > > it does fix the problem before a real patch is submitted. > > >

Re: [Qemu-devel] git master build failure in 9pfs

On Mar 3, 2017, at 10:58 AM, Peter Maydell wrote: On 3 March 2017 at 15:55, G 3 wrote: Here is the patch. I think we should let Mark or some else test it to see if it does fix the problem before a real patch is submitted. --- hw/9pfs/9p-util.h | 4 1 file

Re: [Qemu-devel] git master build failure in 9pfs

On 3 March 2017 at 15:55, G 3 wrote: > Here is the patch. I think we should let Mark or some else test it to see if > it does fix the problem before a real patch is submitted. > > --- > hw/9pfs/9p-util.h | 4 > 1 file changed, 4 insertions(+) We can't take any

Re: [Qemu-devel] git master build failure in 9pfs

On Mar 3, 2017, at 10:44 AM, Greg Kurz wrote: On Fri, 3 Mar 2017 10:28:00 -0500 G 3 wrote: On Mar 3, 2017, at 9:59 AM, qemu-devel-requ...@nongnu.org wrote: On 02/03/17 17:40, Daniel P. Berrange wrote: On Thu, Mar 02, 2017 at 05:28:24PM +, Mark Cave-Ayland

Re: [Qemu-devel] git master build failure in 9pfs

On Fri, 3 Mar 2017 10:28:00 -0500 G 3 wrote: > On Mar 3, 2017, at 9:59 AM, qemu-devel-requ...@nongnu.org wrote: > > On 02/03/17 17:40, Daniel P. Berrange wrote: > > > >> On Thu, Mar 02, 2017 at 05:28:24PM +, Mark Cave-Ayland wrote: > >>> Does anyone else see

Re: [Qemu-devel] git master build failure in 9pfs

On Thu, 2 Mar 2017 18:10:29 + Peter Maydell wrote: > On 2 March 2017 at 17:40, Daniel P. Berrange wrote: > > On Thu, Mar 02, 2017 at 05:28:24PM +, Mark Cave-Ayland wrote: > >> Build platform is Debian Wheezy on an x86_64 host. > > > >

Re: [Qemu-devel] git master build failure in 9pfs

On Mar 3, 2017, at 9:59 AM, qemu-devel-requ...@nongnu.org wrote: On 02/03/17 17:40, Daniel P. Berrange wrote: On Thu, Mar 02, 2017 at 05:28:24PM +, Mark Cave-Ayland wrote: Does anyone else see the following error when trying to build git master? cc

Re: [Qemu-devel] git master build failure in 9pfs

On 02/03/17 17:40, Daniel P. Berrange wrote: > On Thu, Mar 02, 2017 at 05:28:24PM +, Mark Cave-Ayland wrote: >> Does anyone else see the following error when trying to build git master? >> >> cc -I/home/build/src/qemu/git/qemu/hw/9pfs -Ihw/9pfs >> -I/home/build/src/qemu/git/qemu/tcg >>

Re: [Qemu-devel] git master build failure in 9pfs

On Mar 2, 2017, at 1:26 PM, qemu-devel-requ...@nongnu.org wrote: > > Does anyone else see the following error when trying to build git master? > > cc -I/home/build/src/qemu/git/qemu/hw/9pfs -Ihw/9pfs > -I/home/build/src/qemu/git/qemu/tcg > -I/home/build/src/qemu/git/qemu/tcg/i386 >

Re: [Qemu-devel] git master build failure in 9pfs

On 2 March 2017 at 17:40, Daniel P. Berrange wrote: > On Thu, Mar 02, 2017 at 05:28:24PM +, Mark Cave-Ayland wrote: >> Build platform is Debian Wheezy on an x86_64 host. > > IIUC, O_PATH was introduced in glibc 2.14 and Wheezy only has 2.13. > > So unless we want to make

Re: [Qemu-devel] git master build failure in 9pfs

On Thu, Mar 02, 2017 at 05:28:24PM +, Mark Cave-Ayland wrote: > Does anyone else see the following error when trying to build git master? > > cc -I/home/build/src/qemu/git/qemu/hw/9pfs -Ihw/9pfs > -I/home/build/src/qemu/git/qemu/tcg > -I/home/build/src/qemu/git/qemu/tcg/i386 >

[Qemu-devel] git master build failure in 9pfs

Does anyone else see the following error when trying to build git master? cc -I/home/build/src/qemu/git/qemu/hw/9pfs -Ihw/9pfs -I/home/build/src/qemu/git/qemu/tcg -I/home/build/src/qemu/git/qemu/tcg/i386 -I/home/build/src/qemu/git/qemu/linux-headers -I/home/build/src/qemu/git/qemu/linux-headers

Re: [Qemu-devel] git master build failure (migration/colo.c)

On Mon, Oct 31, 2016 at 08:08:46PM +, Mark Cave-Ayland wrote: > I've just done a git pull and get the following build error here: > > cc -I/home/build/src/qemu/git/qemu/tcg > -I/home/build/src/qemu/git/qemu/tcg/i386 > -I/home/build/src/qemu/git/qemu/linux-headers >

[Qemu-devel] git master build failure (migration/colo.c)

I've just done a git pull and get the following build error here: cc -I/home/build/src/qemu/git/qemu/tcg -I/home/build/src/qemu/git/qemu/tcg/i386 -I/home/build/src/qemu/git/qemu/linux-headers -I/home/build/src/qemu/git/qemu/linux-headers -I. -I/home/build/src/qemu/git/qemu

Re: [Qemu-devel] git master build failure

On 06/17/16 14:55, Peter Maydell wrote: > On 17 June 2016 at 13:41, Mark Cave-Ayland > wrote: >> Thank you looking into this. I know that some workarounds have been >> applied for similar bugs in Peter's setup, but in general should I >> assume that out-of-the-box

Re: [Qemu-devel] git master build failure

On 17 June 2016 at 13:41, Mark Cave-Ayland wrote: > Thank you looking into this. I know that some workarounds have been > applied for similar bugs in Peter's setup, but in general should I > assume that out-of-the-box Debian oldstable is now no longer supported > to

Re: [Qemu-devel] git master build failure

On 15/06/16 13:35, Laszlo Ersek wrote: > On 06/15/16 12:08, Mark Cave-Ayland wrote: >> On 15/06/16 10:48, Andrew Jones wrote: >> >>> On Wed, Jun 15, 2016 at 08:14:18AM +0100, Mark Cave-Ayland wrote: Hi Peter, Just to let you know that after pulling git master

Re: [Qemu-devel] git master build failure

On 06/15/16 12:08, Mark Cave-Ayland wrote: > On 15/06/16 10:48, Andrew Jones wrote: > >> On Wed, Jun 15, 2016 at 08:14:18AM +0100, Mark Cave-Ayland wrote: >>> Hi Peter, >>> >>> Just to let you know that after pulling git master >>> (49237b856ae58ee7955be0b959c504c51b014f20) I see the following

Re: [Qemu-devel] git master build failure

On 15/06/16 12:26, Mark Cave-Ayland wrote: > On 15/06/16 11:23, Andrew Jones wrote: > >>> Is that from a clean clone of the repository? I wonder if a change to a >>> generated file isn't being picked up somewhere by "make distclean". My >>> standard build script is this: >> >> Not a clean clone,

Re: [Qemu-devel] git master build failure

On 15/06/16 11:23, Andrew Jones wrote: >> Is that from a clean clone of the repository? I wonder if a change to a >> generated file isn't being picked up somewhere by "make distclean". My >> standard build script is this: > > Not a clean clone, but a clean build dir. I build in a separate build

Re: [Qemu-devel] git master build failure

On Wed, Jun 15, 2016 at 11:08:26AM +0100, Mark Cave-Ayland wrote: > On 15/06/16 10:48, Andrew Jones wrote: > > > On Wed, Jun 15, 2016 at 08:14:18AM +0100, Mark Cave-Ayland wrote: > >> Hi Peter, > >> > >> Just to let you know that after pulling git master > >>

Re: [Qemu-devel] git master build failure

On 15/06/16 10:48, Andrew Jones wrote: > On Wed, Jun 15, 2016 at 08:14:18AM +0100, Mark Cave-Ayland wrote: >> Hi Peter, >> >> Just to let you know that after pulling git master >> (49237b856ae58ee7955be0b959c504c51b014f20) I see the following build >> failure here: > > Just pulled and

Re: [Qemu-devel] git master build failure

On Wed, Jun 15, 2016 at 08:14:18AM +0100, Mark Cave-Ayland wrote: > Hi Peter, > > Just to let you know that after pulling git master > (49237b856ae58ee7955be0b959c504c51b014f20) I see the following build > failure here: Just pulled and successfully compiled, configure

[Qemu-devel] git master build failure

Hi Peter, Just to let you know that after pulling git master (49237b856ae58ee7955be0b959c504c51b014f20) I see the following build failure here: cc -I/home/build/src/qemu/git/qemu/tcg -I/home/build/src/qemu/git/qemu/tcg/i386 -I/home/build/src/qemu/git/qemu/linux-headers