Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-18 Thread Kevin Wolf
Am 18.09.2012 11:48, schrieb Paolo Bonzini: > Il 18/09/2012 11:40, Kevin Wolf ha scritto: >> Note that after completing the refactoring, we'll only have one combined >> bdrv_close/delete function and so there won't be BlockDriverStates >> that are closed. In this case, I think it's quit

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 11:40, Kevin Wolf ha scritto: >>> >> Note that after completing the refactoring, we'll only have one combined >>> >> bdrv_close/delete function and so there won't be BlockDriverStates >>> >> that are closed. In this case, I think it's quite obvious that not >>> >> closing >>> >> the

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-18 Thread Kevin Wolf
Am 18.09.2012 11:09, schrieb Paolo Bonzini: >>> Luckily removable media are usually not too interesting, so a >>> slightly suboptimal behavior is okay as long as it does not break the >>> important use cases---mostly migration without shared storage, where also >>> uninteresting images have to be m

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-18 Thread Paolo Bonzini
> > Luckily removable media are usually not too interesting, so a > > slightly suboptimal behavior is okay as long as it does not break the > > important use cases---mostly migration without shared storage, where also > > uninteresting images have to be mirrored or exposed via NBD. Those > > shou

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-18 Thread Kevin Wolf
Am 17.09.2012 18:43, schrieb Paolo Bonzini: > Il 07/09/2012 18:11, Kevin Wolf ha scritto: >> I was planning to review it in more detail next week, but I just had a >> quick look. I'm not sure if automatically shutting down the NBD server >> when the guest stops using it is always right (for removab

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-17 Thread Paolo Bonzini
Il 07/09/2012 18:11, Kevin Wolf ha scritto: > I was planning to review it in more detail next week, but I just had a > quick look. I'm not sure if automatically shutting down the NBD server > when the guest stops using it is always right (for removable media it > could even be an eject from the gue

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-07 Thread Kevin Wolf
Am 07.09.2012 17:50, schrieb Paolo Bonzini: > Il 27/08/2012 17:00, Paolo Bonzini ha scritto: >> The part where I need >> a second opinion and/or ack is patch 12 and 13. They fix the case of >> a disk being unplugged while NBD export is active. To do this I add a >> NotifierList to a BlockDriverSt

[Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-07 Thread Paolo Bonzini
Il 27/08/2012 17:00, Paolo Bonzini ha scritto: > The part where I need > a second opinion and/or ack is patch 12 and 13. They fix the case of > a disk being unplugged while NBD export is active. To do this I add a > NotifierList to a BlockDriverState. Does this look okay, or is it too > ad hoc?