Re: [Qemu-devel] ppc: CPU reset must flush translation buffer

2012-05-21 Thread Benjamin Herrenschmidt
On Mon, 2012-05-21 at 08:15 +0100, Peter Maydell wrote: > The conclusion we came to is that you only need to tb_flush > in your CPU's reset function if you have some CPU state which > you handle by baking it into translated code and doing a tb_flush > when the state changes. This is relatively rare

Re: [Qemu-devel] ppc: CPU reset must flush translation buffer

2012-05-21 Thread Peter Maydell
On 21 May 2012 07:16, Alexander Graf wrote: > Shouldn't this be true for all CPUs? I remember talking about reset > with Peter a while ago... but don't remember the conclusions :) The conclusion we came to is that you only need to tb_flush in your CPU's reset function if you have some CPU state w

Re: [Qemu-devel] ppc: CPU reset must flush translation buffer

2012-05-20 Thread Benjamin Herrenschmidt
On Mon, 2012-05-21 at 08:16 +0200, Alexander Graf wrote: > > On 21.05.2012, at 04:01, Benjamin Herrenschmidt > wrote: > > > Without that, reset from SLOF crashes in full emulation. > > > > Reported-by: Thomas Huth > > Signed-off-by: Benjamin Herrenschmidt > > --- > > target-ppc/translate_init

Re: [Qemu-devel] ppc: CPU reset must flush translation buffer

2012-05-20 Thread Alexander Graf
On 21.05.2012, at 04:01, Benjamin Herrenschmidt wrote: > Without that, reset from SLOF crashes in full emulation. > > Reported-by: Thomas Huth > Signed-off-by: Benjamin Herrenschmidt > --- > target-ppc/translate_init.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --

[Qemu-devel] ppc: CPU reset must flush translation buffer

2012-05-20 Thread Benjamin Herrenschmidt
Without that, reset from SLOF crashes in full emulation. Reported-by: Thomas Huth Signed-off-by: Benjamin Herrenschmidt --- target-ppc/translate_init.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index ae0306