Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Fri, Sep 23, 2016 at 01:27:19PM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2016-09-23 at 11:37 +1000, David Gibson wrote: > > > > For KVM HV there's a bit of a nit: that would disallow migration > > between host cpus which aren't exactly the same model, but are close > > enough that

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Fri, 2016-09-23 at 11:37 +1000, David Gibson wrote: > > For KVM HV there's a bit of a nit: that would disallow migration > between host cpus which aren't exactly the same model, but are close > enough that migration will work in practice. In that case we should use the architected PVR

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

David Gibson writes: > [ Unknown signature status ] > On Thu, Sep 22, 2016 at 02:34:19PM +0530, Nikunj A Dadhania wrote: >> Benjamin Herrenschmidt writes: >> >> > On Thu, 2016-09-22 at 11:45 +0530, Bharata B Rao wrote: >> >> On Thu, Sep

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Thu, Sep 22, 2016 at 12:32:24PM +0200, Paolo Bonzini wrote: > > > On 22/09/2016 12:04, Benjamin Herrenschmidt wrote: > > On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: > >> Something like this works for KVM: > >> > >> diff --git a/target-ppc/machine.c b/target-ppc/machine.c > >>

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Thu, Sep 22, 2016 at 09:37:16PM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2016-09-22 at 13:27 +0200, Cédric Le Goater wrote: > > > > TCG migration succeeds and proceeds ahead. But fails somewhere > > > ahead in > > > powerpc exception handler: > > > > > > [qemu]$

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Thu, Sep 22, 2016 at 02:34:19PM +0530, Nikunj A Dadhania wrote: > Benjamin Herrenschmidt writes: > > > On Thu, 2016-09-22 at 11:45 +0530, Bharata B Rao wrote: > >> On Thu, Sep 22, 2016 at 04:07:21PM +1000, Benjamin Herrenschmidt wrote: > >> > > >> > On Thu,

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

Cédric Le Goater writes: > On 09/22/2016 01:07 PM, Nikunj A Dadhania wrote: >> Benjamin Herrenschmidt writes: >> >>> On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: Something like this works for KVM: diff --git

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

"Dr. David Alan Gilbert" writes: > * Nikunj A Dadhania (nik...@linux.vnet.ibm.com) wrote: >> Benjamin Herrenschmidt writes: >> >> > On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: >> >> Something like this works for KVM: >> >> >> >>

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

* Nikunj A Dadhania (nik...@linux.vnet.ibm.com) wrote: > Benjamin Herrenschmidt writes: > > > On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: > >> Something like this works for KVM: > >> > >> diff --git a/target-ppc/machine.c b/target-ppc/machine.c > >>

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Thu, 2016-09-22 at 13:27 +0200, Cédric Le Goater wrote: > > TCG migration succeeds and proceeds ahead. But fails somewhere > > ahead in > > powerpc exception handler: > > > > [qemu]$ ./ppc64-softmmu/qemu-system-ppc64  -machine pseries- > > 2.6,usb=off -vga none -nographic -m 2G   

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Thu, 2016-09-22 at 12:32 +0200, Paolo Bonzini wrote: > *However* a better fix would be to preserve the old flags for > pseries-2.6, and only set the newer flags for pseries-2.7.  I'm not > saying you have to do this, but if it's not hard (no idea) why not learn > how to do it right. > > The

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On 09/22/2016 01:07 PM, Nikunj A Dadhania wrote: > Benjamin Herrenschmidt writes: > >> On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: >>> Something like this works for KVM: >>> >>> diff --git a/target-ppc/machine.c b/target-ppc/machine.c >>> index

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

"Dr. David Alan Gilbert" writes: >> > You might find the first two patches in: >> >https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg03681.html >> > useful in debugging this; it prints the values when the _EQUAL macros fail >> > and prints >> > the field name that

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Thu, 2016-09-22 at 20:34 +1000, Alexey Kardashevskiy wrote: > > diff --git a/target-ppc/machine.c b/target-ppc/machine.c > > index 4820f22..1cf3779 100644 > > --- a/target-ppc/machine.c > > +++ b/target-ppc/machine.c > > @@ -563,8 +563,8 @@ const VMStateDescription vmstate_ppc_cpu = { > >   > > 

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

Benjamin Herrenschmidt writes: > On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: >> Something like this works for KVM: >> >> diff --git a/target-ppc/machine.c b/target-ppc/machine.c >> index 4820f22..1cf3779 100644 >> --- a/target-ppc/machine.c >> +++

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On 22/09/2016 12:04, Benjamin Herrenschmidt wrote: > On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: >> Something like this works for KVM: >> >> diff --git a/target-ppc/machine.c b/target-ppc/machine.c >> index 4820f22..1cf3779 100644 >> --- a/target-ppc/machine.c >> +++

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On 22/09/16 19:04, Nikunj A Dadhania wrote: > Benjamin Herrenschmidt writes: > >> On Thu, 2016-09-22 at 11:45 +0530, Bharata B Rao wrote: >>> On Thu, Sep 22, 2016 at 04:07:21PM +1000, Benjamin Herrenschmidt wrote: On Thu, 2016-09-22 at 10:51 +0530, Bharata B

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

* Nikunj A Dadhania (nik...@linux.vnet.ibm.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Bharata B Rao (bhar...@linux.vnet.ibm.com) wrote: > >> On Thu, Sep 22, 2016 at 03:30:08PM +1000, David Gibson wrote: > >> > On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

"Dr. David Alan Gilbert" writes: > * Bharata B Rao (bhar...@linux.vnet.ibm.com) wrote: >> On Thu, Sep 22, 2016 at 03:30:08PM +1000, David Gibson wrote: >> > On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B Rao wrote: >> > > Hi, >> > > >> > > Nikunj and I realized that

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: > Something like this works for KVM: > > diff --git a/target-ppc/machine.c b/target-ppc/machine.c > index 4820f22..1cf3779 100644 > --- a/target-ppc/machine.c > +++ b/target-ppc/machine.c > @@ -563,8 +563,8 @@ const VMStateDescription

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

* Bharata B Rao (bhar...@linux.vnet.ibm.com) wrote: > On Thu, Sep 22, 2016 at 03:30:08PM +1000, David Gibson wrote: > > On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B Rao wrote: > > > Hi, > > > > > > Nikunj and I realized that migrating pseries-2.6 guest from QEMU-2.6 > > > to newer QEMU-2.7

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

Benjamin Herrenschmidt writes: > On Thu, 2016-09-22 at 11:45 +0530, Bharata B Rao wrote: >> On Thu, Sep 22, 2016 at 04:07:21PM +1000, Benjamin Herrenschmidt wrote: >> > >> > On Thu, 2016-09-22 at 10:51 +0530, Bharata B Rao wrote: >> > > >> > > The flag values are

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Thu, 2016-09-22 at 11:45 +0530, Bharata B Rao wrote: > On Thu, Sep 22, 2016 at 04:07:21PM +1000, Benjamin Herrenschmidt wrote: > > > > On Thu, 2016-09-22 at 10:51 +0530, Bharata B Rao wrote: > > > > > > The flag values are expected to remain same for a machine version for > > > the migration

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On 09/22/2016 08:00 AM, Bharata B Rao wrote: > On Thu, Sep 22, 2016 at 03:30:08PM +1000, David Gibson wrote: >> On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B Rao wrote: >>> Hi, >>> >>> Nikunj and I realized that migrating pseries-2.6 guest from QEMU-2.6 >>> to newer QEMU-2.7 is broken like

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Thu, Sep 22, 2016 at 04:07:21PM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2016-09-22 at 10:51 +0530, Bharata B Rao wrote: > > The flag values are expected to remain same for a machine version for > > the migration to succeed, but this expectation is broken now. Should > > we make the

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Thu, 2016-09-22 at 10:51 +0530, Bharata B Rao wrote: > The flag values are expected to remain same for a machine version for > the migration to succeed, but this expectation is broken now. Should > we make the addition of these flags conditional on machine type > version ? > But these flags are

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Thu, Sep 22, 2016 at 03:30:08PM +1000, David Gibson wrote: > On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B Rao wrote: > > Hi, > > > > Nikunj and I realized that migrating pseries-2.6 guest from QEMU-2.6 > > to newer QEMU-2.7 is broken like this: > > > > qemu-system-ppc64: error while

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B Rao wrote: > Hi, > > Nikunj and I realized that migrating pseries-2.6 guest from QEMU-2.6 > to newer QEMU-2.7 is broken like this: > > qemu-system-ppc64: error while loading state for instance 0x0 of device 'cpu' > qemu-system-ppc64: load of

[Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

Hi, Nikunj and I realized that migrating pseries-2.6 guest from QEMU-2.6 to newer QEMU-2.7 is broken like this: qemu-system-ppc64: error while loading state for instance 0x0 of device 'cpu' qemu-system-ppc64: load of migration failed: Invalid argument Bisecting tells us that