Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-12 Thread Igor Mammedov
On Tue, 12 Sep 2017 10:11:32 +0100 Peter Maydell wrote: > On 12 September 2017 at 08:40, Igor Mammedov wrote: > > On Mon, 11 Sep 2017 14:33:03 +0100 > > Peter Maydell wrote: > >> It's not possible in all cases to set a

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-12 Thread Peter Maydell
On 12 September 2017 at 08:40, Igor Mammedov wrote: > On Mon, 11 Sep 2017 14:33:03 +0100 > Peter Maydell wrote: >> It's not possible in all cases to set a CPU property from the >> top level board code. In quite a lot of cases the CPU >> object is

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-12 Thread Igor Mammedov
On Mon, 11 Sep 2017 14:33:03 +0100 Peter Maydell wrote: > On 11 September 2017 at 13:10, Igor Mammedov wrote: > > On Tue, 5 Sep 2017 10:08:01 +0100 > > Peter Maydell wrote: > > > >> On 4 September 2017 at 20:38, Igor

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-11 Thread Peter Maydell
On 11 September 2017 at 13:10, Igor Mammedov wrote: > On Tue, 5 Sep 2017 10:08:01 +0100 > Peter Maydell wrote: > >> On 4 September 2017 at 20:38, Igor Mammedov wrote: >> > On Mon, 4 Sep 2017 17:36:59 +0100 >> > Peter Maydell

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-11 Thread Igor Mammedov
On Tue, 5 Sep 2017 10:08:01 +0100 Peter Maydell wrote: > On 4 September 2017 at 20:38, Igor Mammedov wrote: > > On Mon, 4 Sep 2017 17:36:59 +0100 > > Peter Maydell wrote: > > > >> I just got bitten by

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-05 Thread Peter Maydell
On 4 September 2017 at 20:38, Igor Mammedov wrote: > On Mon, 4 Sep 2017 17:36:59 +0100 > Peter Maydell wrote: > >> I just got bitten by qdev_get_machine()'s behaviour on the user-only >> emulators, where it can return something that isn't NULL and

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-04 Thread Igor Mammedov
On Mon, 4 Sep 2017 17:36:59 +0100 Peter Maydell wrote: > I just got bitten by qdev_get_machine()'s behaviour on the user-only > emulators, where it can return something that isn't NULL and isn't > an instance of TYPE_MACHINE either. user-only shouldn't get to

[Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-04 Thread Peter Maydell
I just got bitten by qdev_get_machine()'s behaviour on the user-only emulators, where it can return something that isn't NULL and isn't an instance of TYPE_MACHINE either. It looks like maybe this can happen in some cases in softmmu too, judging by the way that qdev_get_hotplug_handler() does an